Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handlers not sent when using Composer autoload #38

Merged
merged 1 commit into from
Aug 16, 2012
Merged

Handlers not sent when using Composer autoload #38

merged 1 commit into from
Aug 16, 2012

Conversation

mheap
Copy link

@mheap mheap commented Aug 8, 2012

I have no idea if this is the best way to fix it, but I figured as registerHandlers is idempotent it doesn't really matter. When using httpful via Composer, the Bootstrap.php file isn't loaded at all so the handlers never get registered. This makes sure they're registered every time a request is made.

@nategood
Copy link
Owner

nategood commented Aug 9, 2012

Hmm good catch. Do you know if there is a standard way of handling "Bootstrap" via Composer without mucking up the autoloader? You are right, Bootstrap::init is idempotent, however, placing it in Request reads a little weird :-/.

@mheap
Copy link
Author

mheap commented Aug 9, 2012

Aye, it's not ideal but it was the quickest fix that got it working for me.
Unfortunately I have no idea about Composer, this is my first project using it. If I work it out and you haven't sorted it by then, I'll send a PR in :)

@nategood
Copy link
Owner

I'll go ahead and merge this is so that we can get Composer straightened out. Reads a little funny, but I haven't been able to find an elegant bootstrap process in Composer. I suppose I could have the autoloader call it exactly once, but this too seems hacky.

nategood pushed a commit that referenced this pull request Aug 16, 2012
Handlers not sent when using Composer autoload
@nategood nategood merged commit b1a7eaf into nategood:master Aug 16, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants