Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added comptime convenience functions #55

Merged
merged 11 commits into from
Feb 7, 2024
Merged

Added comptime convenience functions #55

merged 11 commits into from
Feb 7, 2024

Conversation

VisenDev
Copy link
Contributor

This is currently using my old implementations. I'm gonna make a few more improvements still

@VisenDev VisenDev marked this pull request as draft January 30, 2024 16:13
@VisenDev VisenDev marked this pull request as ready for review January 30, 2024 20:30
natecraddock
natecraddock requested changes Jan 31, 2024
View reviewed changes
Copy link
Owner

@natecraddock natecraddock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a very high-level review. I still need to look at things more closely.

I see a few stray comments around still. Should these be removed? Or is there some more missing functionality?

src/lib.zig Outdated Show resolved Hide resolved
src/lib.zig Outdated Show resolved Hide resolved
src/lib.zig Outdated Show resolved Hide resolved
src/lib.zig Outdated Show resolved Hide resolved
src/lib.zig Outdated Show resolved Hide resolved
src/lib.zig Outdated Show resolved Hide resolved
src/tests.zig Outdated Show resolved Hide resolved
@natecraddock
Copy link
Owner

I added a commit recently that should make this easier to implement: a213c57

Now you can just use pushFunction everywhere instead of switching on the language to see if it is luau.

natecraddock
natecraddock requested changes Feb 7, 2024
View reviewed changes
Copy link
Owner

@natecraddock natecraddock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good now. There are still many sections of commented code throughout the lib.zig and tests that should either be uncommented or removed

src/lib.zig Outdated Show resolved Hide resolved
src/lib.zig Outdated Show resolved Hide resolved
src/lib.zig Outdated Show resolved Hide resolved
@natecraddock natecraddock mentioned this pull request Feb 7, 2024
Open
@natecraddock natecraddock merged commit 0f0f489 into natecraddock:main Feb 7, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natecraddock natecraddock natecraddock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VisenDev @natecraddock