Remove vendored code and update to latest module api #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natecraddock
force-pushed
the
update-zig-modules
branch
from
e20056a to
7d075a0
Compare
Use the Zig package manager to download the sources for Lua 5.1 through Lua 5.4. Luau still needs to be done this way. The LuaVersion enum strings are changed to remove the _ characters, this is a breaking change. Also makes the tests rely on the module rather than the raw source file. Not sure if this is a good idea yet, just testing some things. This links the compiled lua library to the ziglua module so it doesn't need to be linked manually in other projects.
natecraddock
force-pushed
the
update-zig-modules
branch
from
7d075a0 to
f9ef420
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes vendored code and updates to recent changes in Zig ziglang/zig#18160