Fix build break for zig 0.14.0-dev.2596 #131
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think CI is not testing luajit. But at least my superficial attempt to look at it failed on Windows, so it might not work to enable it in the makefile with the current GitHub Actions config. |
|
The |
|
Thanks! I'll update the PR to use |
- There's no root_module.addCMacro anymore - There's also no root_module.unwind_tables boolean anymore. Setting "unwind_tables = .sync" should match earlier behavior. for natecraddock#130
nurpax
force-pushed
the
build-fix-0.14-dev.2596
branch
from
2233e8f to
3d36e37
Compare
|
PR updated to use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's no root_module.addCMacro anymore
There's also no root_module.unwind_tables boolean anymore. My fix only fixes the break but I don't know what's the right value to set here. The choices are null, sync, and async. I couldn't get the luajit variant to build on Windows. Maybe merge this and ask the luajit contributor for a proper fix?
for #130