Add value counts under polygons in zonal statistics #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/270-value-counts-under-polygons-in-zonal-statistics
A `Counter` object allows for succinct tallying of landuse codes, so it really makes sense to use in this case. RE:natcap#270
|
@emlys this should be ready to review now! |
3 tasks
emlys
requested changes
Sep 16, 2022
I'm trying to clarify the intent of the function and the created dict ... "sample" isn't a good descriptor for what's going on here. RE:natcap#270
emlys
approved these changes
Sep 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds pixel counts under each polygon and warns the user if pixel counts have been requested on a floating-point raster.
Fixes #270