Close UG windows when main app window is closed

[emlys]

Description

Fixes #1258

Also fixes a similar, mac-specific issue where the app could not be reopened after clicking the red traffic light button.

Checklist

• Updated HISTORY.rst and link to any relevant issue (if these changes are user-facing)
• Updated the user's guide (if needed)
• Tested the affected models' UIs (if relevant)

[davemfish]

@emlys , thanks for the new bug report in #1258 . I think that probably indicates a larger issue in our main process logic. Maybe the fact that much of the code in createWindow assumes that the application is starting up fresh and not already running.

What is your opinion about the right design for MacOS? I see at least 3 options:

1. Stick to MacOS conventions: the red button closes the window but leaves the application running. In which case we need to resolve the above-mentioned bug to allow the window to re-open.
2. Break convention by re-programming the red button to behave like the yellow button.
3. Break convention by re-programming the red button to fully exit the application.

As a general principle I think there needs to be a pretty strong reason to break an OS convention. But I also don't see too much value in the conventional behavior, for the Workbench. I just worry that option 2 will surprise some people. And maybe option 3 would too, I'm not sure.

[davemfish]

Can you describe the implications of this event.preventDefault()?

[emlys]

The default behavior of the window-all-closed event is to quit the app, so the intent is to prevent quitting on macOS. You made me realize it makes more sense to write it this way:

  app.on('window-all-closed', (event) => {
    if (process.platform === 'darwin') {
      event.preventDefault();
    }
  });

[davemfish]

Okay, thanks @emlys . I think the docs are slightly unclear here. One way to read it is that simply subscribing to this event already prevents the default behavior of quitting. And that seems like the way it was working previously, where closing the window did not quit on darwin.

With this configuration closing the window no longer quits the app on Windows. So that makes me think that subscribing to this event already prevents the default behavior. I think we can just revert this back to: ?

  app.on('window-all-closed', () => {
    // On OS X it is common for applications and their menu bar
    // to stay active until the user quits explicitly with Cmd + Q
    if (process.platform !== 'darwin') {
      app.quit();
    }
  });

[emlys]

I think the window-all-closed handler might be unnecessary now, since on mac, we minimize the window instead of closing it. And it seems like we want the default behavior on Windows.

[davemfish]

I know it was already like this, but it looks like we do not need this to be async.

[emlys]

Fixed!

[davemfish]

this no longer quits the app on Windows

[davemfish]

Looks good, thank you!