Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update InVEST for numpy2 #1641

Closed
phargogh opened this issue Oct 8, 2024 · 0 comments · Fixed by #1642
Closed

Update InVEST for numpy2 #1641

phargogh opened this issue Oct 8, 2024 · 0 comments · Fixed by #1642
Assignees
@phargogh
Labels
in progress This issue is actively being worked on task Something needs to be done
Milestone
3.14.3

Comments

@phargogh
Copy link
Member

phargogh commented Oct 8, 2024

Now that pygeoprocessing 2.4.5 is released, we should update InVEST to handle numpy 2.
@phargogh phargogh added task Something needs to be done in progress This issue is actively being worked on labels Oct 8, 2024
@phargogh phargogh self-assigned this Oct 8, 2024
phargogh added a commit to phargogh/invest that referenced this issue Oct 8, 2024
@phargogh
Removing numpy version cap that prevented numpy 2 installation. RE:na…
0ff560b 
…tcap#1641
@phargogh phargogh mentioned this issue Oct 8, 2024
Merged
1 task
phargogh added a commit to phargogh/invest that referenced this issue Oct 10, 2024
@phargogh
Trying to lfs-checkout to the right revision. RE:natcap#1641
670cb7d
phargogh added a commit to phargogh/invest that referenced this issue Oct 10, 2024
@phargogh
Printing the subwatersheds vector for debugging. RE:natcap#1641
56eb76d
phargogh added a commit to phargogh/invest that referenced this issue Oct 10, 2024
@phargogh
Attempting to read the binary file before printing. RE:natcap#1641
595db95
phargogh added a commit to phargogh/invest that referenced this issue Oct 10, 2024
@phargogh
Restoring autovalidate script to its prior state. RE:natcap#1641
3c12306
phargogh added a commit to phargogh/invest that referenced this issue Oct 10, 2024
@phargogh
Capping GDAL to less than 3.9 to see if that fixes the weird opening …
5d42450 
…issues. RE:natcap#1641
phargogh added a commit to phargogh/invest that referenced this issue Oct 10, 2024
@phargogh
Capping the gdal version as an experiment. RE:natcap#1641
e550127
phargogh added a commit to phargogh/invest that referenced this issue Oct 11, 2024
@phargogh
Using logging to record debug info. RE:natcap#1641
82d81ab
@dcdenu4 dcdenu4 added this to the 3.14.3 milestone Oct 15, 2024
phargogh added a commit to phargogh/invest that referenced this issue Oct 15, 2024
@phargogh
Handling numpy 2 build requirements in pyproject.toml. RE:natcap#1641
c28041c
phargogh added a commit to phargogh/invest that referenced this issue Oct 15, 2024
@phargogh
Correcting a toml syntax issue. RE:natcap#1641
e7c7c1a
phargogh added a commit to phargogh/invest that referenced this issue Oct 15, 2024
@phargogh
Bumping the UG repo rev for RST syntax.
dc63302 
An RST error in a footnote in Wave Energy was breaking the binary builds
in the main InVEST repository.  This is now addressed. RE:natcap#1641
phargogh added a commit to phargogh/invest that referenced this issue Oct 15, 2024
@phargogh
Adding a numpy>2 constraint for testing our builds. RE:natcap#1641
e711300
phargogh added a commit to phargogh/invest that referenced this issue Oct 15, 2024
@phargogh
Removing the GDAL upper bound for numpy2 compatibility. RE:natcap#1641
f229373
phargogh added a commit to phargogh/invest that referenced this issue Oct 15, 2024
@phargogh
Removing a no-longer-needed GDAL constraint. RE:natcap#1641
9fdb381
phargogh added a commit to phargogh/invest that referenced this issue Oct 16, 2024
@phargogh
Removing numpy>2 constraint so that environments will resolve on pyth…
b49dea2 
…on 3.8. RE:natcap#1641
phargogh added a commit to phargogh/invest that referenced this issue Oct 16, 2024
@phargogh
Converting numpy.in1d to numpy.isin for numpy2 compatibility. RE:natc…
206c8f0 
…ap#1641
phargogh added a commit to phargogh/invest that referenced this issue Oct 16, 2024
@phargogh
Updating UFRM for numpy2 compatibility.
a43131a 
RE:natcap#1641
phargogh added a commit to phargogh/invest that referenced this issue Oct 16, 2024
@phargogh
Updating UCM tests for numerical outputs.
98904f3 
The numpy2 update was producing slightly different numerical outputs,
but also we weren't asserting that they were numerically close, just
that they had the same number of digits after the decimal ... which
wasn't working well because most of these values were large.

RE:natcap#1641
phargogh added a commit to phargogh/invest that referenced this issue Oct 16, 2024
@phargogh
Fixing an exception related to numpy types.
8f13be5 
This is part of the numpy2 migration. RE:natcap#1641
phargogh added a commit to phargogh/invest that referenced this issue Oct 16, 2024
@phargogh
Converting numpy types to python types for numpy2.
41fcb64 
RE:natcap#1641
phargogh added a commit to phargogh/invest that referenced this issue Oct 16, 2024
@phargogh
Converting types for numpy2 migration.
b250662 
RE:natcap#1641
phargogh added a commit to phargogh/invest that referenced this issue Oct 16, 2024
@phargogh
Updating FCEE for numpy2 compatibility.
ab90c46 
RE:natcap#1641
phargogh added a commit to phargogh/invest that referenced this issue Oct 16, 2024
@phargogh
Using assert_allclose for better numerical comparisons.
63fb888 
RE:natcap#1641
phargogh added a commit to phargogh/invest that referenced this issue Oct 16, 2024
@phargogh
Cleaning up misc. code from debugging. RE:natcap#1641
292c3e2
phargogh added a commit to phargogh/invest that referenced this issue Oct 16, 2024
@phargogh
Removing code left over from debugging.
89d236b 
RE:natcap#1641
phargogh added a commit to phargogh/invest that referenced this issue Oct 16, 2024
@phargogh
Clarifying intent in pyproject.toml
75107e7 
RE:natcap#1641
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@phargogh phargogh

Labels
in progress This issue is actively being worked on task Something needs to be done
Projects
None yet
Milestone
3.14.3
Development

Successfully merging a pull request may close this issue.

Update InVEST to build against numpy 2 phargogh/invest
2 participants
@dcdenu4 @phargogh