Make the -v and -q flags incremental #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI test failures because prior to Python 3.8, argparse won't let you group short flags ( Disabling flag abbreviation is a potentially breaking change, so I think we have to require users on older Python versions to type out |
Prior to Python 3.8, argparse does not allow grouping
of short flags ('-v -v' -> '-vv').
|
More test failures because apparently |
On Windows, "echo 'Hello'" produces "'Hello'", whereas on UNIX it just produces "Hello". This had already been solved in other tests, I just did not see it.
|
Passing at last 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See discussion in #34. This means that it is possible to specify normal verbosity again, even if a default verbosity is configured, and will make it easier to support more verbosity levels than just
-1,0and1in the future.