Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make args work as expected on ref tasks #201

Merged
merged 1 commit into from
Feb 25, 2024
Merged

Make args work as expected on ref tasks #201

merged 1 commit into from
Feb 25, 2024

Conversation

nat-n
Copy link
Owner

@nat-n nat-n commented Feb 24, 2024

Ref tasks can now parse named arguments and template the values into the invocation of the referenced task. Extra args (provided after -- or all args if named arg configured) are appended to the invocation

Additional refactor:

  • Add debug logging that is activated by setting the POE_DEBUG environment variable
  • consolidate logic for getting extra args passed after --
  • Remove extra_args argument from methods for task running in favour of always use
    invocation as the source of truth for CLI args

Related #196

@nat-n nat-n changed the title WIP make args work as expected on ref tasks WIP Make args work as expected on ref tasks Feb 25, 2024
@nat-n nat-n marked this pull request as ready for review February 25, 2024 19:28
@nat-n nat-n changed the title WIP Make args work as expected on ref tasks Make args work as expected on ref tasks Feb 25, 2024
@nat-n nat-n merged commit 49aa93c into development Feb 25, 2024
33 of 34 checks passed
nat-n added a commit that referenced this pull request Apr 14, 2024
Ref tasks can now parse named arguments and template the values into the invocation of the referenced task. Extra args (provided after -- or all args if named arg configured) are appended to the invocation

Additional refactor:

- Add debug logging that is activated by setting the POE_DEBUG environment variable
- consolidate logic for getting extra args passed after --
- Remove extra_args argument from methods for task running in favour of always use
  invocation as the source of truth for CLI args

Related #196
@nat-n nat-n deleted the fix_ref_args branch April 27, 2024 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant