Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

envfile on Windows is opened with ANSI code page #176

Closed
rockallite opened this issue Oct 24, 2023 · 2 comments
Closed

envfile on Windows is opened with ANSI code page #176

rockallite opened this issue Oct 24, 2023 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@rockallite
Copy link

Because the envfile is opened without an explicit encoding, the encoding used is platform-dependent: locale.getencoding() is called to get the current locale encoding, which is ANSI code page on Windows by the way.

So poethepoet will complain about a UTF-8 encoded envfile with non-ASCII characters on Windows. This creates a lot of annoyance. Please fix this, by either allowing the user to specify an encoding for envfile, or opening the envfile with UTF-8 encoding by default. Thank you.

@nat-n
Copy link
Owner

nat-n commented Oct 25, 2023

Hi @rockallite, thanks for the feedback! I'll see about improving this in the next release :)

@nat-n nat-n added the bug Something isn't working label Oct 25, 2023
@nat-n nat-n self-assigned this Oct 25, 2023
@nat-n
Copy link
Owner

nat-n commented Nov 4, 2023

Thanks again for reporting this bug. It's now fixed with v0.24.2 🚀

@nat-n nat-n closed this as completed Nov 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants