Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calls to CFE_SB_Subscribe() are missing return checks #204

Open
2 tasks done
thnkslprpt opened this issue Oct 11, 2024 · 0 comments · May be fixed by #205
Open
2 tasks done

Calls to CFE_SB_Subscribe() are missing return checks #204

thnkslprpt opened this issue Oct 11, 2024 · 0 comments · May be fixed by #205

Comments

@thnkslprpt
Copy link
Contributor

Checklist

  • I reviewed the Contributing Guide.
  • I performed a cursory search to see if the bug report is relevant, not redundant, nor in conflict with other tickets.

Describe the bug
Calls to CFE_SB_Subscribe() are missing return checks in the initialization code.

Code snips

to_lab/fsw/src/to_lab_app.c

Lines 184 to 191 in fe6c9fd

if (status == CFE_SUCCESS)
{
CFE_SB_Subscribe(CFE_SB_ValueToMsgId(TO_LAB_CMD_MID), TO_LAB_Global.Cmd_pipe);
CFE_SB_Subscribe(CFE_SB_ValueToMsgId(TO_LAB_SEND_HK_MID), TO_LAB_Global.Cmd_pipe);
/* Create TO TLM pipe */
status = CFE_SB_CreatePipe(&TO_LAB_Global.Tlm_pipe, ToTlmPipeDepth, ToTlmPipeName);

Expected behavior
Check returns for all critical function calls during initialization.

Reporter Info
Avi Weiss   @thnkslprpt

thnkslprpt added a commit to thnkslprpt/to_lab that referenced this issue Oct 11, 2024
@thnkslprpt thnkslprpt linked a pull request Oct 11, 2024 that will close this issue
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant