Feature/issue 230 allow single file netcdf filepath input #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #231 +/- ##
===========================================
+ Coverage 85.01% 86.18% +1.16%
===========================================
Files 11 11
Lines 634 637 +3
===========================================
+ Hits 539 549 +10
+ Misses 95 88 -7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ank1m
approved these changes
Aug 13, 2024
danielfromearth
deleted the
feature/issue-230-allow-single-file-netcdf-filepath-input
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue: #230
Description
Until now, when a single path was passed to stitchee, the file needed to be a text file containing a separate filepath on each line. With this change, a single path is also allowed to be a netCDF file — in which case, the file will be copied to the output path without modification.
Local test steps
A new unit test was added, and all tests passed.
Overview of integration done
Integration tests passed.
PR Acceptance Checklist
CHANGELOG.mdupdated📚 Documentation preview 📚: https://stitchee--231.org.readthedocs.build/en/231/