Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RTEMS 5 needs size_t type to build #732

Closed
zanzaben opened this issue Jan 4, 2021 · 0 comments · Fixed by #733 or #750
Closed

RTEMS 5 needs size_t type to build #732

zanzaben opened this issue Jan 4, 2021 · 0 comments · Fixed by #733 or #750
Assignees
@zanzaben
Labels
bug RTEMS
Milestone
Caelum

Comments

@zanzaben
Copy link
Contributor

zanzaben commented Jan 4, 2021

Describe the bug
There are a few methods that won't build in rtmes 5 because they use uint32 instead of size_t

Relevant Files and line numbers:
bsp_console.c 44
os-impl-network.c 60
os-impl-queues.c 159, 256
os-impl-tasks.c 376

To Reproduce
Build for RTEMS 5 per instructions and default config. Build fails.

Expected behavior
Build should succeed.

System observed on:
Ubuntu 20.04 as build host for RTEMS 5.0.0

Reporter Info
Alex Campbell GSFC
@zanzaben zanzaben self-assigned this Jan 4, 2021
zanzaben added a commit to zanzaben/osal that referenced this issue Jan 4, 2021
@zanzaben
Fix nasa#732 change uint32 to size_t
2b4fc63
@zanzaben zanzaben mentioned this issue Jan 4, 2021
Merged
zanzaben added a commit to zanzaben/osal that referenced this issue Jan 11, 2021
@zanzaben
Fix nasa#732 change uint32 to size_t
efd7f35
@astrogeco astrogeco added this to the 6.0.0 milestone Jan 13, 2021
astrogeco added a commit that referenced this issue Jan 13, 2021
@astrogeco
Merge pull request #733 from zanzaben/Fix732_rtems_5_conflicting_types
b1f1b27 
Fix #732, change uint32 to size_t
@astrogeco astrogeco mentioned this issue Jan 13, 2021
Merged
jphickey pushed a commit to jphickey/osal that referenced this issue Aug 10, 2022
@skliper
Fix nasa#796, Remove dependency on CCSDS version define
b70a1a3 
- Removes MESSAGE_FORMAT_IS_CCSDS_VER2 and all references
- Now replaced by MISSION_MSGID_V2 and MISSION_INCLUDE_CCSDS_HEADER
  cmake variables
- Base MIDs localized to cpu1_msgids.h and improved documentation
  indicating example nature of implementation, note issue nasa#732
  may make this obsolete
- Updated cfe_sb.dox for message module concept
- MsgId base type now always uint32 (reduces logic differences)
- Removed system log report of version used, in build and obvious
  from packet sizes
- Cleaned extra documentation from cfe_sb_msg_id_util.c
- Removed verification limits on CFE_PLATFORM_SB_MAX_MSG_IDS
- Removed UT_GetActualPktLenField and UT_GetActualCmdCodeField
  that depended on the define, shouldn't directly access message
  in a unit test since it's implementation dependent
- Default CCSDS version default now always 0 (per the standard)
  but mission configurable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zanzaben zanzaben

Labels
bug RTEMS
Projects
None yet
Milestone
Caelum
2 participants
@zanzaben @astrogeco