Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add shared layer API for handling global mutex #476

Closed
jphickey opened this issue May 19, 2020 · 0 comments · Fixed by #478 or #482
Closed

Add shared layer API for handling global mutex #476

jphickey opened this issue May 19, 2020 · 0 comments · Fixed by #478 or #482
Labels
enhancement
Milestone
Bootes

Comments

@jphickey
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Currently the shared layer calls OS_Lock_Global_Impl() and OS_Unlock_Global_Impl() directly when locking/unlocking the internal tables within OSAL.

This does not offer a place to:

  • check return code of operation
  • track ownership of resource in case of not being freed.

Describe the solution you'd like
Should implement OS_Lock_Global() and OS_Unlock_Global() wrappers at the shared API level, which can provide a common place to check status, handle failure, and track resource usage.

Additional context
In #474, the global table lock was correctly returning an error but nothing ever checked the return code. Rather than adding a specific return code test everywhere this is used, simpler and better to add a wrapper.

Requester Info
Joseph Hickey, Vantage Systems, Inc.
jphickey added a commit to jphickey/osal that referenced this issue May 19, 2020
@jphickey
Fix nasa#476, add global lock/unlock wrapper
d67819d 
Add a wrapper at the shared layer to provide a common location
to check the status of global lock/unlock ops.

All calls to OS_Lock_Global_Impl and OS_Unlock_Global_Impl from
the shared modules are replaced with calls to this wrapper.
jphickey added a commit to jphickey/osal that referenced this issue May 19, 2020
@jphickey
Fix nasa#476, add global lock/unlock wrapper
393c2ef 
Add a wrapper at the shared layer to provide a common location
to check the status of global lock/unlock ops.

All calls to OS_Lock_Global_Impl and OS_Unlock_Global_Impl from
the shared modules are replaced with calls to this wrapper.
@jphickey jphickey mentioned this issue May 19, 2020
Merged
jphickey added a commit to jphickey/osal that referenced this issue May 20, 2020
@jphickey
Fix nasa#476, add global lock/unlock wrapper
c426de3 
Add a wrapper at the shared layer to provide a common location
to check the status of global lock/unlock ops.

All calls to OS_Lock_Global_Impl and OS_Unlock_Global_Impl from
the shared modules are replaced with calls to this wrapper.
jphickey added a commit to jphickey/osal that referenced this issue May 20, 2020
@jphickey
Fix nasa#476, add global lock/unlock wrapper
4ef9c18 
Add a wrapper at the shared layer to provide a common location
to check the status of global lock/unlock ops.

All calls to OS_Lock_Global_Impl and OS_Unlock_Global_Impl from
the shared modules are replaced with calls to this wrapper.
jphickey added a commit that referenced this issue May 27, 2020
@jphickey
Merge pull request #478 from jphickey/fix-476-global-mutex-wrapper
5c8a01c 
Fix #476, add global lock/unlock wrapper
@astrogeco astrogeco mentioned this issue May 27, 2020
Merged
@skliper skliper added this to the v5.1.0 milestone Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
Bootes
2 participants
@jphickey @skliper