Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve ABORT handling in RTEMS unit test #457

Closed
jphickey opened this issue May 13, 2020 · 0 comments · Fixed by #465 or #482
Closed

Improve ABORT handling in RTEMS unit test #457

jphickey opened this issue May 13, 2020 · 0 comments · Fixed by #465 or #482
Assignees
Labels
enhancement unit-test Tickets related to the OSAL unit testing (functional and/or coverage)
Milestone

Comments

@jphickey
Copy link
Contributor

Is your feature request related to a problem? Please describe.
If an unit testing error occurs that causes the test to abort, the implementation just calls the system abort() function. In RTEMS, this causes the entire system/kernel to shutdown. This leaves no ability to use the shell to check the system state or diagnose what went wrong.

Describe the solution you'd like
Defer handling of the abort to the BSP. In RTEMS, when the shell is available, this should just suspend the calling task to stop the tests, allowing the shell to continue being used.

Additional context
This used to be the case, but probably an artifact of merging the UT BSP with regular BSP that this got lost in translation, and it only shows up if an abort failure occurs. Fairly trivial/easy to add it back in though.

Requester Info
Joseph Hickey, Vantage Systems, Inc.

@jphickey jphickey self-assigned this May 13, 2020
@skliper skliper added this to the 5.1.0 milestone May 13, 2020
jphickey added a commit to jphickey/osal that referenced this issue May 14, 2020
This provides a better method of handling test abort,
in a BSP-specific manner.
astrogeco added a commit that referenced this issue May 26, 2020
@astrogeco astrogeco added the unit-test Tickets related to the OSAL unit testing (functional and/or coverage) label Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement unit-test Tickets related to the OSAL unit testing (functional and/or coverage)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants