Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cppcheck warning ut-stubs #305

Closed
avan989 opened this issue Dec 11, 2019 · 0 comments · Fixed by #334
Closed

cppcheck warning ut-stubs #305

avan989 opened this issue Dec 11, 2019 · 0 comments · Fixed by #334
Labels
unit-test Tickets related to the OSAL unit testing (functional and/or coverage)
Milestone

Comments

@avan989
Copy link
Contributor

avan989 commented Dec 11, 2019

Is your feature request related to a problem? Please describe.
cppcheck warning from #301

[osal/src/ut-stubs/osapi-utstub-file.c:108] -> [osal/src/ut-stubs/osapi-utstub-file.c:110]: (style) Variable 'status' is reassigned a value before the old one has been used.
[osal/src/ut-stubs/osapi-utstub-file.c:147] -> [osal/src/ut-stubs/osapi-utstub-file.c:149]: (style) Variable 'status' is reassigned a value before the old one has been used.
[osal/src/ut-stubs/osapi-utstub-mutex.c:127] -> [osal/src/ut-stubs/osapi-utstub-mutex.c:129]: (style) Variable 'status' is reassigned a value before the old one has been used.
[osal/src/ut-stubs/osapi-utstub-mutex.c:156] -> [osal/src/ut-stubs/osapi-utstub-mutex.c:158]: (style) Variable 'status' is reassigned a value before the old one has been used.
[osal/src/ut-stubs/osapi-utstub-queue.c:102] -> [osal/src/ut-stubs/osapi-utstub-queue.c:104]: (style) Variable 'status' is reassigned a value before the old one has been used.
[osal/src/ut-stubs/osapi-utstub-queue.c:145] -> [osal/src/ut-stubs/osapi-utstub-queue.c:147]: (style) Variable 'status' is reassigned a value before the old one has been used.
[osal/src/ut-stubs/osapi-utstub-queue.c:186] -> [osal/src/ut-stubs/osapi-utstub-queue.c:188]: (style) Variable 'status' is reassigned a value before the old one has been used.
[osal/src/ut-stubs/osapi-utstub-task.c:157] -> [osal/src/ut-stubs/osapi-utstub-task.c:159]: (style) Variable 'status' is reassigned a value before the old one has been used.
[osal/src/ut-stubs/osapi-utstub-task.c:182] -> [osal/src/ut-stubs/osapi-utstub-task.c:184]: (style) Variable 'status' is reassigned a value before the old one has been used.
[osal/src/ut-stubs/utstub-helpers.c:194]: (style) Variable 'InUse' is modified but its new value is never used.

Describe the solution you'd like
resolve cppcheck warning

Requester Info
Anh Van, NASA Goddard

@skliper skliper added this to the 5.1.0 milestone Dec 11, 2019
skliper added a commit that referenced this issue Dec 30, 2019
Fix #295, #298, #305, #307, #308,
    #313, #314, #316, #321, #323
Reviewed and approved at 2019-12-18 CCB
@astrogeco astrogeco added unit-test Tickets related to the OSAL unit testing (functional and/or coverage) and removed enhancement labels Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
unit-test Tickets related to the OSAL unit testing (functional and/or coverage)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants