Make tree items more actionable and add AppAction for expanding the object tree #5997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5997 +/- ##
==========================================
- Coverage 54.70% 54.41% -0.29%
==========================================
Files 607 607
Lines 25959 25943 -16
Branches 2349 2350 +1
==========================================
- Hits 14200 14118 -82
- Misses 11098 11164 +66
Partials 661 661
*This pull request uses carry forward flags. Click here to find out more.
Continue to review full report at Codecov.
|
|
Blocked temporarily. Waiting to upgrade to the version with this fix in it: microsoft/playwright#18920 Now also waiting for this fix to drop: microsoft/playwright#18976 (v1.28.2 or v1.29.x) |
unlikelyzero
approved these changes
Jan 5, 2023
- The purpose of this is so that Playwright can perform actionability checks on the tree items. This will make operations involving expanding tree items much easier to perform in e2e.
- Use dynamic aria-label for different tree implementations - Get rid of CSS ids which are only for testing - Update percy tree scope selector
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Updated the appAction to be able to take a tree selector so we can use this against both trees. Also updated trees to use |
unlikelyzero
approved these changes
Jan 26, 2023
ozyx
added a commit
that referenced
this pull request
Jan 26, 2023
… for expanding the object tree * style: add `visibility` to tree expand triangles - The purpose of this is so that Playwright can perform actionability checks on the tree items. This will make operations involving expanding tree items much easier to perform in e2e. * feat(e2e): Add AppAction to expand the entire tree * fix: wait for loading indicator * test: add test for `expandEntireTree` * test: update `expandEntireTree` and tree selectors - Use dynamic aria-label for different tree implementations - Get rid of CSS ids which are only for testing - Update percy tree scope selector * chore(lint): remove unused variable * refactor(e2e): update tree locators Co-authored-by: John Hill <[email protected]>
unlikelyzero
added a commit
that referenced
this pull request
Jan 26, 2023
… for expanding the object tree (#6200) * style: add `visibility` to tree expand triangles - The purpose of this is so that Playwright can perform actionability checks on the tree items. This will make operations involving expanding tree items much easier to perform in e2e. * feat(e2e): Add AppAction to expand the entire tree * fix: wait for loading indicator * test: add test for `expandEntireTree` * test: update `expandEntireTree` and tree selectors - Use dynamic aria-label for different tree implementations - Get rid of CSS ids which are only for testing - Update percy tree scope selector * chore(lint): remove unused variable * refactor(e2e): update tree locators Co-authored-by: John Hill <[email protected]> Co-authored-by: John Hill <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5994
Describe your changes:
visibilitycss attributes to the.c-disclosure-triangleon the object tree, so that we can better locate expandable tree items within Playwright.All Submissions:
Author Checklist
Reviewer Checklist