Harmony 571 daac regression tests #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s to overcome timeouts
…m/nasa/harmony-regression-tests into harmony-571-daac-regression-tests
asteiker
requested review from
bilts,
rwat,
indiejames,
chris-durbin and
eigenbeam
bilts
requested changes
Mar 5, 2021
test/Dockerfile
Outdated
| COPY .netrc .netrc | ||
| RUN mkdir ./${sub_dir} | ||
| COPY ${sub_dir}/conda-linux-64.lock ./${sub_dir} | ||
| RUN ls ${sub_dir} |
There was a problem hiding this comment.
Debugging statement. Should be removed.
| @@ -0,0 +1,377 @@ | |||
| from contextlib import contextmanager | |||
There was a problem hiding this comment.
There are possibly parts of this we could trim down or exclude, based on not caring much about the visual output in the current notebooks. I'd vote for leaving it as is for now but revisiting once we revamp the existing notebooks to use the newly-developed Python lib.
There was a problem hiding this comment.
Doing the trimming down could remove a number of hefty dependencies in the current code
bilts
approved these changes
Mar 8, 2021
flamingbear
added a commit
that referenced
this pull request
Jan 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the regression notebook in the Harmony repo (HarmonyRegression.ipynb) and copied into /test/harmony-regression. Added necessary
harmony_host_urlvariable and modified each test to ensure compatibility across providers. Also added a few lines to test intake-stac compatibility of zarr outputs but left direct access of outputs commented out due to known issues with stac (intake/intake-stac#48). A few assumptions:This branch also has several updates and fixes that James completed including updates to the notebook helper functions under /test/harmony-regression to get some of the plotting working in the docker environment, and fixed a timeout issue to enable aws testing.