Parse fully qualified comp instance name in JSON loaders #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update spelling
thomas-bc
requested changes
Aug 8, 2024
There was a problem hiding this comment.
Looks good to me!
Could you also update the test cases in https://github.com/nasa/fprime-gds/blob/devel/test/fprime_gds/common/loaders/test_json_loader.py to include a qualified name for its associated Ref dictionary (provided in the test folder)?
|
Thanks @thomas-bc. I updated the JSON loader test and Ref dictionary to include the qualified names. |
thomas-bc
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
As part of nasa/fpp#349, command, events, telemetry channel, etc. names are now fully qualified in the JSON dictionary. This PR updates how we parse the component instance names in the comment, event, and channel JSON loaders so that the fully qualified name is included.
Rationale
Needed for compatibility with nasa/fpp#349
Testing/Review Recommendations
Ran FPrime Ref deployment and tested it with changes introduced in this PR. Confirmed that the command, event, and channel names are fully qualified. Was able to successfully send commands and filter commands/telemetry.