Ci workflow #16
Ci workflow #16
Conversation
| @@ -54,7 +54,6 @@ def sample_event(sample_template): | |||
| filtering_utils.get_search_predicate("the same combination"), | |||
| ], | |||
| ) | |||
| @pytest.mark.gds_cli | |||
There was a problem hiding this comment.
Do we need to remove these markers to get everything working? I haven't used pytest much, so I definitely don't know what I'm talking about, but I assumed that pytest would just run everything by default. If tests have already been marked they're probably worth keeping just on the off chance somebody running locally just wants to run the cli tests or something.
There was a problem hiding this comment.
Yeah, if you have the markers but don't define them then it gives a bunch of warnings. Should I add them back in then?
There was a problem hiding this comment.
Ah, I get it now. Yeah, add the pytest.ini file back in. Something tells me nobody has been running these unit tests anytime recently.
Sorry for the churn on the pytest markers... looks good to me now!
| @@ -0,0 +1,25 @@ | |||
| name: fprime-gds tests | |||
|
|
|||
| on: [pull_request] | |||
There was a problem hiding this comment.
Can you please make this workflow triggered on both pull requests and pushes (so that it runs on the devel branch as well)
|
@aidan-wagner what tests does this run? Do we have pytests in GDS that aren't integration tests? |
|
@aidan-wagner i stand corrected. Looks good! |
Change Description
Added fprime-gds tests to workflow
Rationale
To ensure fprime-gds is not broken by future updates
Future Work
Create tests to ensure backwards compatability