Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing ids argument #131

Merged
merged 1 commit into from
May 17, 2023
Merged

Fixing ids argument #131

merged 1 commit into from
May 17, 2023

Conversation

SMorettini
Copy link
Contributor

@SMorettini SMorettini commented May 15, 2023 •
edited
Loading

Originating Project/Creator
Affected Component
Affected Architectures(s)
Related Issue(s)
Has Unit Tests (y/n)
Builds Without Errors (y/n)
Unit Tests Pass (y/n)
Documentation Included (y/n)

Change Description

The --ids parameter was converted to an int but an iterable was requested for the filter. I changed the type of the param to fix the error and support multiple ids.

The nargs is documented here.

thomas-bc
thomas-bc approved these changes May 16, 2023
View reviewed changes
Copy link
Collaborator

@thomas-bc thomas-bc left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Argh, that's my bad, seems I missed the nargs when I moved that around in 6846ece. (for reference, see here).
Thanks for catching that and making the fix!
LGTM.

@LeStarch LeStarch merged commit 20b76d6 into nasa:devel May 17, 2023
@SMorettini SMorettini deleted the Fixing-filter-channel-events-with-ids branch August 3, 2023 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomas-bc thomas-bc thomas-bc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SMorettini @thomas-bc @LeStarch