Refactor fprime-cli #119
Merged
Refactor fprime-cli #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeStarch
approved these changes
Mar 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Refactoring
fprime-clito use the StandardPipelineParser and a better pattern to instantiate the StandardPipeline and IntegrationTestAPI objects. Also fixes #112.I am also adding a workflow to test that
fprime-cli <subcommand>loads up successfully to prevent future unnoticed breakages.Rationale
Prompted by the breakage of
fprime-cliafter the re-writing of the Parsers.Future work
More thorough integration testing should be added in the CI.
Additional comment
For the CI workflow, I originally added checks on the output of each
fprime-clisubcommand to compare the number of channels/events/commands - but this was kind of dependent on the syntax of the output (I was using grep since json output is currently broken) and would add some maintenance burden if there are changes, so I scratched it. Let me know if you want me to work that back in.