Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing missing logs by flattening out log folder structure #116

Merged
merged 2 commits into from
Feb 17, 2023

Conversation

LeStarch
Copy link
Collaborator

Originating Project/Creator
Affected Component
Affected Architectures(s)
Related Issue(s)
Has Unit Tests (y/n)
Builds Without Errors (y/n)
Unit Tests Pass (y/n)
Documentation Included (y/n)

Change Description

Fixes nasa/fprime#1885.

The "calculate a dated folder" code for logging only needs be run once. All other logging (including over in the flask process) should be direct to that folder.

@LeStarch LeStarch requested a review from LMPS97 February 10, 2023 02:41
@thomas-bc thomas-bc requested review from thomas-bc and removed request for LMPS97 February 13, 2023 23:51
thomas-bc
thomas-bc previously approved these changes Feb 17, 2023
Copy link
Collaborator

@thomas-bc thomas-bc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Added a small comment since we're in there

src/fprime_gds/executables/cli.py Show resolved Hide resolved
@LeStarch
Copy link
Collaborator Author

@thomas-bc fixed! Ready for merge?

Copy link
Collaborator

@thomas-bc thomas-bc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready!

@LeStarch LeStarch merged commit 0512ff5 into nasa:devel Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deployment (i.e. Ref) Log Not Showing in Logs Tab
2 participants