Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Input file Description/TableName without terminator causes segfault #43

Closed
skliper opened this issue May 26, 2020 · 1 comment · Fixed by #46
Closed

Input file Description/TableName without terminator causes segfault #43

skliper opened this issue May 26, 2020 · 1 comment · Fixed by #46
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@skliper
Copy link
Contributor

skliper commented May 26, 2020

Describe the bug
Segfault at:

elf2cfetbl/elf2cfetbl.c

Line 2379 in 8e54e26

strcpy(FileHeader.Description, TblFileDef.Description);

Likely also an issue with TableName:

elf2cfetbl/elf2cfetbl.c

Line 2412 in 8e54e26

strcpy(TableHeader.TableName, TblFileDef.TableName);

To Reproduce
Steps to reproduce the behavior:

  1. Create a table input file with a 32 byte description (no null terminator)
  2. Run elf2cfetbl

Expected behavior
Error or warn/truncate.

Code snips
See above

System observed on:

  • Versions: Master bundle

Additional context
Identified by JSC

Reporter Info
Jacob Hageman - NASA/GSFC
@skliper skliper added bug Something isn't working good first issue Good for newcomers labels May 26, 2020
@skliper skliper linked a pull request Jan 26, 2021 that will close this issue
Fix #45 - null terminates src/dst filenames #46
Merged
@skliper
Copy link
Contributor Author

skliper commented Jan 26, 2021

This was fixed by #43.

@skliper skliper closed this as completed Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #45 - null terminates src/dst filenames CDKnightNASA/elf2cfetbl
1 participant
@skliper