Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EDSC-4326: Updating node and replacing node-sass with sass #79

Closed
wants to merge 6 commits into from

Conversation

trevorlang
Copy link
Collaborator

Overview

What is the feature?

Updates to a supported version of node and removes node-sass to fix installation issues related to its deprecation.

What is the Solution?

  • Uses node version lts/jod
  • Removes node-sass in favor of sass

What areas of the application does this impact?

While doing the change to sass I noticed the opportunity to fix some issues with the sass structure, example, and linting to clean up the project and improve dev UX.

Testing

Reproduction steps

  1. Load the demo site
  2. Confirm all demo pages work as expected

Attachments

Please include relevant screenshots or files that would be helpful in reviewing and verifying this change.

Checklist

  • I have added automated tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Copy link

codecov bot commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (fdd5794) to head (dc9f76a).

Additional details and impacted files
@@            Coverage Diff             @@
##              main       #79    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           23        17     -6     
  Lines          719       128   -591     
  Branches       182        14   -168     
==========================================
- Hits           719       128   -591     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reminding myself to update edsc-eslint-config

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant