EDSC-3846: Updates eslint config #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macrouch
requested review from
trevorlang,
Bccorb,
bnp26,
rushgeo,
dpesall,
daniel-zamora and
eudoroolivares2016
Codecov Report
@@ Coverage Diff @@
## main #76 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 23 23
Lines 719 719
Branches 182 182
=========================================
Hits 719 719
|
dpesall
approved these changes
Sep 21, 2023
src/index.js
Outdated
Comment on lines
1491
to
1510
| // maxDate: PropTypes.number, // maximum date timeline will allow scrolling | ||
| // MaxDate: PropTypes.number, // maximum date timeline will allow scrolling | ||
| // minDate: PropTypes.number, // minimum date timeline will allow scrolling |
There was a problem hiding this comment.
Is it expected that the linter likes MaxDate to be PascalCase and minDate to be camel case?
There was a problem hiding this comment.
Should be lower m, its an annoying part of one rule.
But those values aren't even being used anymore, so I'll delete them
eudoroolivares2016
approved these changes
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
What is the feature?
Updates eslint configs to new shared config