-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci_lab Integration Candidate: 2020-12-08 #65
Conversation
- Use CFE_SB_Buffer_t for receiving and casting to command types - Use CFE_MSG_CommandHeader_t and CFE_MSG_TelemetryHeader_t in command and telemetry type definitions - Use CFE_SB_TransmitMsg to copy the command and telemetry into a CFE_SB_Buffer_t and send it where needed - Avoids need to create send buffers within the app (or union the packet types with CFE_SB_Buffer_t) - Eliminates references to CFE_SB_CmdHdr_t and CFE_SB_TlmHdr_t that formerly enforced alignment since these had potential to change the actual packet sizes - No need to cast to CFE_MSG_Message_t anywhere since it's available in the CFE_SB_Buffer_t union
- Replaced CFE_SB_RcvMsg with CFE_SB_ReceiveBuffer - Replaced CFE_MSG_Size_t with size_t
Fix #62, Apply message alignment pattern
@skliper having some trouble after merging #63 See https://github.com/astrogeco/cFS/runs/1481379928?check_suite_focus=true
|
@astrogeco - yup, won't work until the fix for nasa/cFE#1009 (nasa/cFE#1015) is in. |
a41cb9a
to
6057f9c
Compare
6057f9c
to
dee470d
Compare
@skliper got an error when running cFS
|
@astrogeco I was able to recreate on a dev vm, so not specific to your setup. |
@astrogeco pushed hotfix. I shouldn't have removed the cast on the size comparison to catch negative return status. |
Describe the contribution
Fix #62, Apply message alignment pattern
Testing performed
See https://github.com/nasa/cFS/pull/160/checks
Expected behavior changes
PR #63 - Aligns messages according to changes in cFE nasa/cFE#1009. Uses the "raw" message cmd/tlm types in definition
System(s) tested on
Ubuntu 18.04
Additional context
Part of nasa/cFS#160
Third party code
None
Contributor Info - All information REQUIRED for consideration of pull request
@skliper