Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce standard coding style in CI #24

Closed
skliper opened this issue Nov 6, 2019 · 1 comment · Fixed by #31
Closed

Enforce standard coding style in CI #24

skliper opened this issue Nov 6, 2019 · 1 comment · Fixed by #31
Labels
enhancement New feature or request
Milestone
Bootes

Comments

@skliper
Copy link
Contributor

skliper commented Nov 6, 2019 •
edited
Loading

Is your feature request related to a problem? Please describe.
Inconsistent formatting

Describe the solution you'd like
Once nasa/cFS#38 is in, enforce in CI

Describe alternatives you've considered
Tried indent but didn't support editor integration
Settled on clang-format, requires version 10 for define alignment

Additional context
None

Requester Info
Jacob Hageman - NASA/GSFC
@skliper skliper added the enhancement New feature or request label Dec 17, 2019
@skliper skliper mentioned this issue Jan 2, 2020
Merged
@skliper
Copy link
Contributor Author

skliper commented Jan 2, 2020

Investigated clang-format, and the "Align consecutive #define macros" feature which is only available in clang-format-10 is key to the current cFS style. Unfortunately 10 is not released, so not clear how stable it would be for enforcing style in CI. Could be worth running all the code through once and try enforcing, and if the enforced code changes too much just disable the test.

@skliper skliper changed the title Apply standard formatting, enforce in CI, and ignore *~ files Apply standard formatting, enforce in CI Jan 6, 2020
@skliper skliper changed the title Apply standard formatting, enforce in CI Enforce standard coding style in CI Jan 6, 2020
skliper added a commit that referenced this issue Jan 6, 2020
@skliper
Fix #24, Enforce style in CI
e9fe1d7
skliper added a commit that referenced this issue Jan 6, 2020
@skliper
Fix #24, Enforce style in CI
a473959
skliper added a commit that referenced this issue Jan 6, 2020
@skliper
Fix #24, Enforce style in CI
041f426
@skliper skliper mentioned this issue Jan 6, 2020
Closed
skliper added a commit that referenced this issue Jan 14, 2020
@skliper
Merge pull request #28 from nasa/fix24-standard-format
d46de5f 
Fix #24, Enforce standard style in CI
@skliper skliper mentioned this issue Jan 15, 2020
Merged
@astrogeco astrogeco added this to the 2.4.0 milestone Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
Bootes
Development

Successfully merging a pull request may close this issue.

Integration Candidate 20200108 nasa/ci_lab
2 participants
@skliper @astrogeco