CCB: 2023.04.27

Items for Discussion

@havencarlson

cFE PR #2303 Fix #1901, remove else statement that was unreachable by unit tests

@chillfig

MM PR #74 Fix #66, Adds local variables for command buffer processing

@skliper

cFE PR #2295 Fix #219, #93, Add EVS port timestamp and simplify port selection

@jphickey

LC PR #89 Fix #86, split configuration

cFE PR #2306 Fix #2305, document CFS component file naming

@thnkslprpt

CF PR #337 Fix #336, Apply consistent Event ID names to common events

CF PR #339 Fix #338, Move 'EID' to the end of Event ID names

CS PR #53 Fix #52, Apply consistent Event ID names to common events

CS PR #81 Fix #80, Update Command Code underscores for consistency

DS PR #105 Fix #104, Convert int32 return codes and variables to CFE_Status_t

DS PR #61 Fix #60, Apply consistent Event ID names to common events

FM PR #100 Fix #99, Convert int32 return codes and variables to CFE_Status_t

FM PR #60 Fix #59, Apply consistent Event ID names to common events

FM PR #96 Fix #95, Update command handler function message pointers and return

FM PR #98 Fix #97, Remove redundant use of "dummy" in test code

HK PR #27 Fix #26, Apply consistent Event ID names to common events

HK PR #52 Fix #51, Convert int32 return codes and variables to CFE_Status_t

HS PR #101 Fix #100, Convert int32 return codes and variables to CFE_Status_t

HS PR #51 Fix #50, Apply consistent Event ID names to common events

HS PR #94 Fix #93, Remove CFE_BIT-related macros

LC PR #46 Fix #45, Apply consistent Event ID names to common events

LC PR #48 Fix #16, Convert LC state macros to enums

LC PR #50 Fix #49, Move variables declared mid-function to the top

LC PR #54 Fix #53, Remove stray refs to old event type constants

LC PR #68 Fix #36, Refactor LC_TableInit to remove multiple returns

LC PR #78 Fix #77, Add break to default case of switch in LC_VerifyMsgLength

LC PR #80 Fix #79, Combine consecutive, mutually-exclusive status checks

LC PR #91 Fix #90, Convert int32 return codes and variables to CFE_Status_t

MD PR #37 Fix #36, Apply consistent Event ID names to common events

MD PR #49 Fix #48, Remove unintentionally repeated identical assert

MD PR #51 Fix #50, Convert int32 return codes and variables to CFE_Status_t

MM PR #51 Fix #50, Apply consistent Event ID names to common events

MM PR #52 Fix #8, Remove unnecessary characters from memory dump event

MM PR #53 Fix #21, Add MM_SegmentBreak() to MM_FillMem()

MM PR #68 Fix #67, Use size_t for 'size' variables

MM PR #71 Fix #70, Remove redundant use of "dummy" in test code

MM PR #73 Fix #72, Convert int32 return codes and variables to CFE_Status_t

SC PR #61 Fix #60, Apply consistent Event ID names to common events

SC PR #77 Fix #76, Squash static analysis (CodeQL) uninitialized variable warning

SC PR #79 Fix #78, Split up multiple-variable declaration statements

SC PR #81 Fix #5, Use OS_stat instead of OS_OpenCreate to verify file existence

SC PR #86 Fix #85, Remove CFE_BIT-related macros

SC PR #88 Fix #87, Update Command Code underscores for consistency

SC PR #90 Fix #89, Convert int32 return codes and variables to CFE_Status_t

cFE PR #2247 Fix #1332, Resolve compiler warnings re. signedness comparisons

cFE PR #2248 Fix #1449, Factor out common code for bitmask check

cFE PR #2250 Fix #2249, Align mismatched function prototype/implem. parameter name

cFE PR #2261 Fix #2260, Convert CFE_TBL_INFO_TABLE_LOCKED into a negative error code

cFE PR #2264 Fix #921, Update remaining cFE source/tests to use CFE_Status_t

cFE PR #2265 Fix #1093, Align Pipe ID/Name reporting in SB event strings

cFE PR #2266 Fix #1303, Add struct for Version Info in ES HK Tlm Packet

cFE PR #2267 Fix #1443, Replace for loop copy with single memcpy

cFE PR #2268 Fix #1424, Add event for NumEventFilters over max and remove FilterLimit variable

cFE PR #2269 Fix #1422, Replace UT_DisplayPkt() with UtPrintx()

cFE PR #2270 Fix #1409, Add additional context to log file write error event

cFE PR #2271 Fix #1408, Use LogFullFlag instead of checking LogCount

cFE PR #2272 Fix #1407, Add error report on EVS failure during log header write

cFE PR #2273 Fix #1466, Add status return to CFE_ES_WaitForStartupSync()

cFE PR #2274 Fix #1528, Move NO_SUCH_TABLE_ERR_EID into FindTableInRegistry and make optional

cFE PR #2276 Fix #1515, Remove unnecessary memset from CFE_TBL_LoadFromFile

cFE PR #2278 Fix #1708, Align padding explicitly in cfe_tbl_msg.h

cFE PR #2279 Fix #1723, Add NULL check for AppFileName parameter in CFE_ES_ReloadApp

cFE PR #2281 Fix #2280, Move calls to CFE_ES_GetAppName() higher to reduce code duplication

cFE PR #2283 Fix #2282, Move calls to CFE_SB_GetPipeName() up higher to reduce duplication

cFE PR #2285 Fix #1473, Add helper for CFE_SB_Write...InfoCmd() with common logic

cFE PR #2286 Fix #1467, Add syslog write for CFE_ES_WaitForSystemState() timeout

cFE PR #2294 Fix #1453, Remove sparsely used CFE_BIT-related macros

cFE PR #2302 Fix #1527, Implement common command-handler return pattern across cFE

cFE PR #2304 Fix #1684, Add functional tests for cFE SB Message ID APIs

cFE PR #2308 Fix #1398, Consistent use of CFE_EVS_EventType_Enum_t for EventType

cFE PR #2309 Fix #1448, Simplify and clarify EVS_AddLog logic

cFS-GroundSystem PR #233 Fix #218, Update LogOverflowCounter Description

cFS-GroundSystem PR #235 Fix #234, Update incorrect variable descriptions in tlm.txt

cFS-GroundSystem PR #236 Fix #220, Add missing description fields to cfe-es-hk-tlm.txt

ci_lab PR #130 Fix #129, Apply consistent Event ID names to common events

ci_lab PR #131 Fix #52, Add version information to NOOP event

ci_lab PR #132 Fix #96, Check returns from CFE calls during init

ci_lab PR #139 Fix #138, Convert int32 return codes and variables to CFE_Status_t

elf2cfetbl PR #122 Fix #91, Redo SymbolNames malloc to remove out-of-bounds write

elf2cfetbl PR #123 Fix #85, Add checks for all return values from fseek()

elf2cfetbl PR #124 Fix #86, Check return from chmod

elf2cfetbl PR #125 Fix #87, Check return value of stat()

elf2cfetbl PR #127 Fix #126, Move variables declared mid-function to the top

elf2cfetbl PR #134 Fix #133, Update references to CFE_FS_Header_t time members

osal PR #1331 Fix #1330, Move variables declared mid-function to the top

osal PR #1354 Fix #1353, Align mismatched function prototype/implem. parameter names

osal PR #1357 Fix #1356, Remove stray remaining 'goto' in OSAL test code

osal PR #1364 Fix #1109, Remove unimplemented test stub prototype

osal PR #1368 Fix #1107, Remove unreachable branch (superfluous if condition)

osal PR #1377 Fix #958, Convert some UT_GetStubCount to UtAssert_STUB_COUNT

osal PR #1378 Fix #1103, Implement OS_ERR_INVALID_PRIORITY return code check for RTEMS

osal PR #1379 Fix #1193, Change format of UtAssert_StringBufCompare

osal PR #1381 Fix #1380, Light coding standards cleanup

psp PR #380 Fix #379, Align mismatched function prototype/implem. parameter names

psp PR #381 Fix #274, Cleanup and add doxygen for cfe_psp.h

psp PR #383 Fix #382, Replace exit(1) and exit(-1) with EXIT_FAILURE macro

psp PR #388 Fix #387, Replace hand-written function names with func

sample_app PR #189 Fix #188, Apply consistent Event ID names to common events

sample_app PR #195 Fix #194, Remove component-specific cFE header #includes

sample_app PR #198 Fix #197, Refactor SAMPLE_APP_Init/Process to remove multiple returns

sample_app PR #200 Fix #199, Add test for missing branch in SAMPLE_APP_Process()

sample_app PR #201 Fix #141, Zero out global data structure during initialization

sample_app PR #205 Fix #45, Move cmds and utils into separate files

sch_lab PR #134 Fix #133, Remove component-specific cFE header #includes

sch_lab PR #142 Fix #141, Convert int32 return codes and variables to CFE_Status_t

to_lab PR #134 Fix #133, Apply consistent Event ID names to common events

to_lab PR #146 Fix #145, Refactor mutually exclusive logic in if, else if block

to_lab PR #148 Fix #147, Add check for failure of CFE_EVS_Register() during initialization

to_lab PR #156 Fix #155, Convert int32 return codes and variables to CFE_Status_t