Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #51, Convert int32 return codes and variables to CFE_Status_t #52

Merged
merged 1 commit into from
May 18, 2023
Merged

Fix #51, Convert int32 return codes and variables to CFE_Status_t #52

merged 1 commit into from
May 18, 2023

Conversation

thnkslprpt
Copy link
Contributor

Checklist

Describe the contribution

Testing performed
GitHub CI actions all passing successfully.

Expected behavior changes
No change to behavior.
CFE_Status_t is more expressive and improves consistency with cFE/cFS.

Contributor Info
Avi Weiss @thnkslprpt

github-advanced-security[bot]
github-advanced-security bot found potential problems Apr 23, 2023
View reviewed changes
fsw/src/hk_app.c
@@ -128,9 +128,9 @@
/* HK application initialization routine */
/* */
/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
int32 HK_AppInit(void)
CFE_Status_t HK_AppInit(void)

Check notice

Code scanning / CodeQL

Function too long

HK_AppInit has too many lines (86, while 60 are allowed).
fsw/src/hk_utils.c
@@ -261,7 +261,7 @@
/* HK Tear down old copy table */
/* */
/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
int32 HK_TearDownOldCopyTable(hk_copy_table_entry_t *CpyTblPtr, hk_runtime_tbl_entry_t *RtTblPtr)
CFE_Status_t HK_TearDownOldCopyTable(hk_copy_table_entry_t *CpyTblPtr, hk_runtime_tbl_entry_t *RtTblPtr)

Check notice

Code scanning / CodeQL

Long function without assertion

All functions of more than 10 lines should have at least one assertion.
fsw/src/hk_utils.c
@@ -114,7 +114,7 @@
/* HK process new copy table */
/* */
/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
int32 HK_ProcessNewCopyTable(hk_copy_table_entry_t *CpyTblPtr, hk_runtime_tbl_entry_t *RtTblPtr)
CFE_Status_t HK_ProcessNewCopyTable(hk_copy_table_entry_t *CpyTblPtr, hk_runtime_tbl_entry_t *RtTblPtr)

Check notice

Code scanning / CodeQL

Long function without assertion

All functions of more than 10 lines should have at least one assertion.
fsw/src/hk_app.c
@@ -220,9 +220,9 @@
/* HK application table initialization routine */
/* */
/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
int32 HK_TableInit(void)
CFE_Status_t HK_TableInit(void)

Check notice

Code scanning / CodeQL

Long function without assertion

All functions of more than 10 lines should have at least one assertion.
fsw/src/hk_app.c
@@ -128,9 +128,9 @@
/* HK application initialization routine */
/* */
/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
int32 HK_AppInit(void)
CFE_Status_t HK_AppInit(void)

Check notice

Code scanning / CodeQL

Long function without assertion

All functions of more than 10 lines should have at least one assertion.
fsw/src/hk_utils.c
@@ -261,7 +261,7 @@
/* HK Tear down old copy table */
/* */
/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
int32 HK_TearDownOldCopyTable(hk_copy_table_entry_t *CpyTblPtr, hk_runtime_tbl_entry_t *RtTblPtr)
CFE_Status_t HK_TearDownOldCopyTable(hk_copy_table_entry_t *CpyTblPtr, hk_runtime_tbl_entry_t *RtTblPtr)

Check notice

Code scanning / CodeQL

Function too long

HK_TearDownOldCopyTable has too many lines (90, while 60 are allowed).
fsw/src/hk_utils.c
@@ -114,7 +114,7 @@
/* HK process new copy table */
/* */
/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
int32 HK_ProcessNewCopyTable(hk_copy_table_entry_t *CpyTblPtr, hk_runtime_tbl_entry_t *RtTblPtr)
CFE_Status_t HK_ProcessNewCopyTable(hk_copy_table_entry_t *CpyTblPtr, hk_runtime_tbl_entry_t *RtTblPtr)

Check notice

Code scanning / CodeQL

Function too long

HK_ProcessNewCopyTable has too many lines (141, while 60 are allowed).
fsw/src/hk_app.c
@@ -220,9 +220,9 @@
/* HK application table initialization routine */
/* */
/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
int32 HK_TableInit(void)
CFE_Status_t HK_TableInit(void)

Check notice

Code scanning / CodeQL

Function too long

HK_TableInit has too many lines (81, while 60 are allowed).
@dzbaker dzbaker requested a review from chillfig April 27, 2023 18:36
chillfig
chillfig approved these changes May 18, 2023
View reviewed changes
Copy link
Contributor

@chillfig chillfig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@dzbaker dzbaker merged commit 406ec64 into nasa:main May 18, 2023
@thnkslprpt thnkslprpt deleted the fix-51-convert-int32-return-codes-to-CFE_Status_t branch May 18, 2023 21:22
@dmknutsen dmknutsen added this to the Equuleus milestone May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chillfig chillfig chillfig approved these changes

Assignees
No one assigned
Labels
CCB:Approved enhancement Equuleus-rc1
Projects
None yet
Milestone
Equuleus
Development

Successfully merging this pull request may close these issues.

HK int32 return codes and variables should be converted to CFE_Status_t
4 participants
@thnkslprpt @chillfig @dzbaker @dmknutsen