Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #621, update action versions to v3 #622

Merged
merged 2 commits into from
Dec 6, 2022

Conversation

jphickey
Copy link
Contributor

Checklist (Please check before submitting)

Describe the contribution
Update cache, checkout, and upload-artifact actions from v2 to v3. Should be a drop-in replacement and removes a warning about node.js 12 deprecation.

Fixes #621

Testing performed
Run all github workflows

Expected behavior changes
No more warnings about node.js 12 deprecation

System(s) tested on
Github hosted runner

Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.

Update cache, checkout, and upload-artifact actions from v2 to v3.
Should be a drop-in replacement and removes a warning about node.js 12
deprecation.
@jphickey jphickey added the CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) label Nov 25, 2022
@ArielSAdamsNASA
Copy link
Contributor

@jphickey Looks good, but I don't see where the node.js warning is removed. For example, click the Format Check workflow triggered by this PR and take a look at the workflow file. It uses v3, but the warning is still there. Here is a link: https://github.com/nasa/cFS/actions/runs/3535753791

@jphickey
Copy link
Contributor Author

jphickey commented Dec 1, 2022

@jphickey Looks good, but I don't see where the node.js warning is removed. For example, click the Format Check workflow triggered by this PR and take a look at the workflow file. It uses v3, but the warning is still there. Here is a link: https://github.com/nasa/cFS/actions/runs/3535753791

Thanks for catching that, it looks like the warning in that particular run was from the 3rd-party action "gsactions/commit-message-checker@v1", not the github actions that were updated in this PR.

We'll need to see if there is an update/new version from the original author. I'll check that. I'd still recommend merging this PR, as it fixes most of them - there may be some left but I can take care of those as they appear.

Update from v1 to v2 on this 3rd party action
@jphickey
Copy link
Contributor Author

jphickey commented Dec 1, 2022

I checked and yes, the "commit-message-checker" does have a version 2 now. So I pushed another commit (see 5a1174f) that updates this action from v1 to v2 and the warning is gone. See https://github.com/nasa/cFS/actions/runs/3593359346.

We will just have to keep an eye out for remaining deprecation warnings and watch for new versions of whatever action is triggering them. Problem is when there are a lot, things get buried, so even if this may not fix 100% of the warnings, it will make the remaining ones easier to spot and fix.

@dzbaker dzbaker added CCB:Approved Indicates code review and approval by community CCB and removed CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) labels Dec 1, 2022
dzbaker added a commit that referenced this pull request Dec 6, 2022
*Combines:*

osal v6.0.0-rc4+dev173
cFE v7.0.0-rc4+dev229

**Includes:**

*cFS*
- #622
- #625
- #626
- #582

*osal*
- nasa/osal#1342
- nasa/osal#1341
- nasa/osal#1321

*cFE*
- nasa/cFE#2215
- nasa/cFE#2219
- nasa/cFE#2217
- nasa/cFE#2222

Co-authored by: Joseph Hickey <[email protected]>
Co-authored by: Daniel Knutsen <[email protected]>
Co-authored by: Avi Weiss: <[email protected]>
@dzbaker dzbaker mentioned this pull request Dec 6, 2022
2 tasks
dzbaker added a commit that referenced this pull request Dec 6, 2022
*Combines:*

osal v6.0.0-rc4+dev173
cFE v7.0.0-rc4+dev229

**Includes:**

*cFS*
- #622
- #625
- #626
- #582

*osal*
- nasa/osal#1342
- nasa/osal#1341
- nasa/osal#1321

*cFE*
- nasa/cFE#2215
- nasa/cFE#2219
- nasa/cFE#2217
- nasa/cFE#2222

Co-authored by: Joseph Hickey <[email protected]>
Co-authored by: Daniel Knutsen <[email protected]>
Co-authored by: Avi Weiss: <[email protected]>
@dzbaker dzbaker merged commit 75ce7fb into nasa:main Dec 6, 2022
@jphickey jphickey deleted the fix-621-action-versions branch April 4, 2023 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CCB:Approved Indicates code review and approval by community CCB
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warning about node.js 12 deprecation in github actions
3 participants