Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #13, Remove .DS_Store file, add this file to .gitignore. #70

Merged
merged 1 commit into from
Apr 21, 2020
Merged

Fix #13, Remove .DS_Store file, add this file to .gitignore. #70

merged 1 commit into from
Apr 21, 2020

Conversation

zacnyjegomosc
Copy link
Contributor

@zacnyjegomosc zacnyjegomosc commented Apr 8, 2020 •
edited by skliper
Loading

Describe the contribution
Fixes #13.

Testing performed
Steps taken to test the contribution:

  • Run bash command: find . -name ".DS_Store"

Expected behavior changes

  • No impact to behavior

System(s) tested on

  • Hardware: MacBook Pro
  • OS: macOS
  • Versions: Catalina (10.15.3)

Additional context
N/A

Third party code
N/A

Contributor Info - All information REQUIRED for consideration of pull request
Marek Glijer
Personal

  • HAND SIGNED Individual CLA must be on file (once per release): Individual CLA

edit - By @skliper, fixed issue fixed statement to autolink

@skliper skliper added enhancement New feature or request pending CLA CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) labels Apr 9, 2020
@skliper skliper added this to the 2.2.0 milestone Apr 9, 2020
@skliper
Copy link
Contributor

skliper commented Apr 9, 2020

Thanks @zacnyjegomosc, if you can give me a heads up when you email the CLA I'll keep an eye out for it.

@zacnyjegomosc
Copy link
Contributor Author

Thanks @zacnyjegomosc, if you can give me a heads up when you email the CLA I'll keep an eye out for it.

@skliper Roger that, all clear.

@astrogeco astrogeco added duplicate This issue or pull request already exists CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) and removed CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) duplicate This issue or pull request already exists labels Apr 14, 2020
@skliper
Copy link
Contributor

skliper commented Apr 15, 2020

CCB 20200415 - APPROVED

@zacnyjegomosc
Copy link
Contributor Author

Thanks @zacnyjegomosc, if you can give me a heads up when you email the CLA I'll keep an eye out for it.

It's done @skliper . I've sent my hand-signed CLA via e-mail, a minute ago (to: [email protected]).

@skliper
Copy link
Contributor

skliper commented Apr 16, 2020

Confirmed CLA receipt.

@astrogeco astrogeco added CCB:Approved Indicates approval by CCB CCB - 20200401 and removed CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) labels Apr 20, 2020
@astrogeco astrogeco changed the base branch from master to integration-candidate April 21, 2020 22:09
@astrogeco astrogeco changed the title Remove .DS_Store file, add this file to .gitignore. Fix #13, Remove .DS_Store file, add this file to .gitignore. Apr 21, 2020
@astrogeco astrogeco merged commit 6787bec into nasa:integration-candidate Apr 21, 2020
@astrogeco astrogeco mentioned this pull request Apr 27, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skliper skliper skliper approved these changes

Assignees
No one assigned
Labels
CCB:Approved Indicates approval by CCB enhancement New feature or request
Projects
None yet
Milestone
Bootes
Development

Successfully merging this pull request may close these issues.

Remove .DS_Store file
3 participants
@zacnyjegomosc @skliper @astrogeco