Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#13 Remove .DS_Store from Repo #42

Closed
wants to merge 2 commits into from
Closed

#13 Remove .DS_Store from Repo #42

wants to merge 2 commits into from

Conversation

JarrettCFranklin
Copy link

Describe the contribution
Fixes issues #13

Testing performed
Steps taken to test the contribution:

  1. Validated that .DS_Store was not in the commit and in the repository after change.

Expected behavior changes
A clear and concise description of how this contribution will change behavior and level of impact.

  • No changes to functionality.

System(s) tested on:

  • Hardware
  • OS: Windows 10

Additional context
N/A

Contributor Info
Jarrett C. Franklin
Cahaba Consulting Services

Community contributors
You must attach a signed CLA (required for acceptance) or reference one already submitted

@JarrettCFranklin
bugfix: Remove DS_Store from repo
6f31086 
- Cleared git cache and readded files
- Added .DS_Store to .gitignore
implements: Issue #13
@JarrettCFranklin
Bugfix: #13 Remove DS_Store from Repo
81853c6 
- Added .DS_Store to gitignore

- Cleared git cache and readded files

implements: Issue #13
skliper
skliper requested changes Dec 16, 2019
View reviewed changes
Copy link
Contributor

@skliper skliper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only change as part of this pull request should be the removal of .DS_Store. May need to rebase on current master branch? Also should be just one commit (squash if needed).

@JarrettCFranklin
Copy link
Author

Do you want .DS_Store to be added to gitignore as well or just delete the file?

@skliper
Copy link
Contributor

skliper commented Dec 17, 2019

Do you want .DS_Store to be added to gitignore as well or just delete the file?

Just delete .DS_Store. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skliper skliper skliper requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JarrettCFranklin @skliper