Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified TLM for SB & TBL #122

Closed
wants to merge 4 commits into from
Closed

Modified TLM for SB & TBL #122

wants to merge 4 commits into from

Conversation

evanfitzgerald
Copy link
Contributor

Describe the contribution
A clear and concise description of what the contribution is.

  • Corrected values so SB and TBL tlm pages load when selected to open. (removing buffer error)

Testing performed
Steps taken to test the contribution:
Ran the ground system:
make (in cmdUtil)
python3 GroundSystem.py
Started Telemetry (with Tlm enabled)
Opened Tlm for TBL and SB

Expected behavior changes
Now SB and TBL tlm pages open

System(s) tested on
Tested on a Raspberry Pi

Additional context

Third party code

Contributor Info - All information REQUIRED for consideration of pull request
Evan Fitzgerald (Personal)

@astrogeco
Copy link
Contributor

Thanks for the contribution! We'll review it in the next week or so.

@skliper skliper added this to the 2.3.0 milestone Aug 21, 2020
@astrogeco astrogeco modified the milestones: 2.3.0, 3.0.0 Jan 27, 2021
@astrogeco
Copy link
Contributor

astrogeco commented Feb 2, 2021

Hi @evanfitzgerald thank you for your contribution! Could you sign and email the appropriate Contributor License agreement?

email it to: [email protected] and copy [email protected]

Thanks!

@evanfitzgerald
Copy link
Contributor Author

@astrogeco No problem, I will send it now! :)

@astrogeco
Copy link
Contributor

astrogeco commented Feb 2, 2021

@astrogeco No problem, I will send it now! :)

Got it!

@skliper
Copy link
Contributor

skliper commented Mar 5, 2021

@zanzaben or @evanfitzgerald - could you open an issue (detail steps to recreate bug) and link it?

@evanfitzgerald - Once the issue is open, could you update your commit messages to the following pattern:

Fix #XXX - Short description

Long description (optional)

@skliper skliper added the CCB:Ignore Pull Request is NOT ready for discussion. Has open actions. Will be re-examined at by next CCB. label Mar 5, 2021
@skliper
Copy link
Contributor

skliper commented Mar 5, 2021

Marking as ignore until the steps above are completed (remove CCB:Ignore and add CCB:Ready once complete).

@evanfitzgerald
Copy link
Contributor Author

@zanzaben @skliper - I opened the issue #165. I "redid" the pull request by reforking the repo and making my changes again and naming the commit properly as I had issues with renaming my multiple pushed commits.

@evanfitzgerald
Copy link
Contributor Author

@skliper @zanzaben I additionally redid the pull request as I wasn't sure if this one was still applicable. Please delete it (#166) if it is not needed.

@skliper skliper added the duplicate This issue or pull request already exists label Mar 8, 2021
@skliper skliper removed this from the 3.0.0 milestone Mar 8, 2021
@skliper
Copy link
Contributor

skliper commented Mar 8, 2021

Duplicate of #166

@skliper skliper marked this as a duplicate of #166 Mar 8, 2021
@skliper skliper closed this Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CCB:Ignore Pull Request is NOT ready for discussion. Has open actions. Will be re-examined at by next CCB. duplicate This issue or pull request already exists
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants