Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration Candidate: 2020-09-16 #891

Merged
merged 9 commits into from
Sep 22, 2020
Merged

Integration Candidate: 2020-09-16 #891

merged 9 commits into from
Sep 22, 2020

Conversation

yammajamma
Copy link
Contributor

@yammajamma yammajamma commented Sep 17, 2020

Describe the contribution
Fix #830
Fix #881
Fix #882
Fix #886

Testing performed
Bundle CI - https://github.com/nasa/cFS/pull/140/checks

Expected behavior changes
PR #853 - Sets Revision to 99 for development build.
PR #884 - Installs unit test to target directory.
PR #883 - Returns processor ID to default to unbreak toolchain
PR #887 - Applies the appid/taskid/counterid pattern to Library resources.

System(s) tested o
Ubuntu - CI

Additional context
nasa/cFS#140

Contributor Info - All information REQUIRED for consideration of pull request
Gerardo E. Cruz-Ortiz, NASA-GSFC
Jacob Hageman, NASA-GSFC
Joseph Hickey, Vantage Systems, Inc.

astrogeco and others added 8 commits September 1, 2020 21:26
The version number macros major, minor, and revision, are used in the HK telemetry which can lead to confusion.
Apply the appid/taskid pattern to Library resources.
No real logic change - just putting repeated logic into
inline functions.
Fix #830, Set Revision to 99 for development build
Fix #882, Returned processor ID to default to unbreak toolchain
Fix #881, Install unit test to target directory
@yammajamma yammajamma merged commit 983157d into main Sep 22, 2020
yammajamma added a commit to nasa/cFS that referenced this pull request Sep 22, 2020
yammajamma added a commit to nasa/cFS that referenced this pull request Sep 22, 2020
@skliper skliper added this to the 7.0.0 milestone Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants