Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #580, Deprecate CFE_OS_ abstracted error codes #582

Merged
merged 1 commit into from
Apr 21, 2020
Merged

Fix #580, Deprecate CFE_OS_ abstracted error codes #582

merged 1 commit into from
Apr 21, 2020

Conversation

skliper
Copy link
Contributor

@skliper skliper commented Apr 2, 2020 •
edited
Loading

Describe the contribution
Fix #580 - deprecates CFE_OS_ abstracted OS error codes
Added CFE_OMIT_DEPRECATED_6_7 just to be consistent
Also fix #552 - removes non-existent codes

Testing performed
Steps taken to test the contribution:

  1. CI - see https://travis-ci.com/github/skliper/cFS/builds/157872188

Expected behavior changes
None

System(s) tested on

  • Hardware: AMD
  • OS: Ubuntu 18.04
  • Versions: bundle + this change

Additional context
None

Third party code
None

Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC

@skliper skliper added this to the 6.8.0 milestone Apr 2, 2020
@skliper
Fix nasa#580, Deprecate CFE_OS_ abstracted error codes
fe700b7 
Added CFE_OMIT_DEPRECATED_6_7 just to be consistent
Also fix nasa#552 - removes non-existent codes
@skliper skliper force-pushed the fix580-deprecate-cfe-os-error-codes branch from 48391b5 to fe700b7 Compare April 2, 2020 16:08
@skliper
Copy link
Contributor Author

skliper commented Apr 2, 2020

Amended commit message - wrong issue link

@skliper skliper added the CCB:Ready Ready for discussion at the Configuration Control Board (CCB) label Apr 9, 2020
@astrogeco
Copy link
Contributor

CCB 20200415 - APPROVED

@skliper skliper mentioned this pull request Apr 17, 2020
Merged
@astrogeco astrogeco added CCB:Approved Indicates code review and approval by community CCB CCB - 20200415 and removed CCB:Ready Ready for discussion at the Configuration Control Board (CCB) labels Apr 20, 2020
@astrogeco astrogeco changed the base branch from master to integration-candidate April 21, 2020 22:17
@astrogeco astrogeco merged commit 9f7de0f into nasa:integration-candidate Apr 21, 2020
@astrogeco astrogeco mentioned this pull request Apr 27, 2020
Merged
@skliper skliper deleted the fix580-deprecate-cfe-os-error-codes branch February 1, 2021 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CCB:Approved Indicates code review and approval by community CCB enhancement
Projects
None yet
Milestone
Bootes
Development

Successfully merging this pull request may close these issues.

Deprecate all CFE_OS error codes Remove undefined error defines in cfe_error.h
2 participants
@skliper @astrogeco