Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #392, cpp check warning #393

Merged
merged 1 commit into from
Nov 15, 2019
Merged

Fix #392, cpp check warning #393

merged 1 commit into from
Nov 15, 2019

Conversation

avan989
Copy link
Contributor

@avan989 avan989 commented Nov 5, 2019

Describe the contribution
Fix #392, resolve cpp check warning

Testing performed
Steps taken to test the contribution:

  1. cppcheck --force .
  2. verify warning is gone

System observed on:
Hardware

  1. Ubuntu18.04
  2. Cppcheck 1.82, cFE 6.7.1, osal 5.0.1

Contributor Info
Anh Van, NASA Goddard

Community contributors
You must attach a signed CLA (required for acceptance) or reference one already submitted

@skliper skliper added the CCB:Approved Indicates code review and approval by community CCB label Nov 7, 2019
@skliper skliper merged commit 5310c75 into nasa:master Nov 15, 2019
@skliper
Copy link
Contributor

skliper commented Nov 15, 2019

Note - prematurely merged to master, reverted and merged to integration candidate

skliper added a commit that referenced this pull request Nov 15, 2019
@skliper
20191106/13: Merge #387 #390 #391 #393 #395 #400
a11f38b 
Fixes #379, Fixes #380, Fixes #383, Fixes #384,
Fixes #385, Fixes #292
Code reviewed and approved at 20191106 and 20191113 CB
skliper added a commit that referenced this pull request Nov 30, 2019
@skliper
20191106/13: Merge #387 #390 #391 #393 #395 #400
9aedaab 
Fixes #379, Fixes #380, Fixes #383, Fixes #384,
Fixes #385, Fixes #392
Code reviewed and approved at 20191106 and 20191113 CB
@skliper skliper added this to the 6.8.0 milestone Dec 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skliper skliper skliper approved these changes

Assignees
No one assigned
Labels
CCB:Approved Indicates code review and approval by community CCB
Projects
None yet
Milestone
Bootes
Development

Successfully merging this pull request may close these issues.

cpp check error
2 participants
@avan989 @skliper