Fix #2337, add msg verify capability #2338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a "verify" API to the msg module. This always returns success in the default implementation, because checksums were not historically enforced. However it can be made more strict in a custom implementation.
jphickey
added
the
CCB:Ready
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| /* | ||
| * Test MSG Verify | ||
| */ | ||
| void Test_MSG_Verify(void) |
Check notice
Code scanning / CodeQL
Long function without assertion
dzbaker
added
CCB:Approved
2 tasks
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
May 22, 2023
*Combines:* cFE v7.0.0-rc4+dev318 sch_lab v2.5.0-rc4+dev57 **Includes:** *cFE* - nasa/cFE#2336 - nasa/cFE#2338 *sch_lab* - nasa/sch_lab#145 Co-authored by: Daniel Knutsen <[email protected]> Co-authored by: Joseph Hickey <[email protected]>
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
May 22, 2023
*Combines:* cFE v7.0.0-rc4+dev318 sch_lab v2.5.0-rc4+dev57 **Includes:** *cFE* - nasa/cFE#2336 - nasa/cFE#2338 *sch_lab* - nasa/sch_lab#144 Co-authored by: Daniel Knutsen <[email protected]> Co-authored by: Joseph Hickey <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist (Please check before submitting)
Describe the contribution
Adds a "verify" API to the msg module. This always returns success in the default implementation, because checksums were not historically enforced. However it can be made more strict in a custom implementation.
Fixes #2337
Testing performed
Build and run tests (API is not used yet)
Expected behavior changes
None at this time, follow on change to enable it
System(s) tested on
Debian
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.