Fix #1931 Support unimplemented features in MSG ft #1941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pepepr08
commented
Sep 9, 2021
Comment on lines
+126
to
+130
| CFE_Assert_STATUS_STORE(CFE_SB_TransmitMsg(&CFE_FT_BigMsg.Hdr, true)); | ||
| if (!CFE_Assert_STATUS_MAY_BE(CFE_SUCCESS)) | ||
| { | ||
| CFE_Assert_STATUS_MUST_BE(CFE_SB_BAD_ARGUMENT); | ||
| } |
There was a problem hiding this comment.
@skliper I had to do this because every MID is valid for them, but I'm not convinced this is the right way to handle that scenario and I can't think of a better way.
pepepr08
added
the
CCB:Ready
skliper
approved these changes
Sep 9, 2021
|
@astrogeco as long as others approve could we get this one in main soon? |
jphickey
approved these changes
Sep 9, 2021
There was a problem hiding this comment.
As a side note, I may actually need that "CFE_MSG_GenerateChecksum" part for the EDS stuff I'm working on too. The checksum exists (of course) but its handled differently and there is no reason for an app to read the checksum directly, so better to return NOT_IMPLEMENTED from the MSG Api.
zanzaben
approved these changes
Sep 10, 2021
astrogeco
force-pushed
the
integration-candidate
branch
from
6311022
to
51c6398
Compare
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Sep 10, 2021
2 tasks
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Sep 10, 2021
**Combines** nasa/cFE#1939, v6.8.0-rc1+dev994 nasa/osal#1145, v5.1.0-rc1+dev604 nasa/PSP#307, v1.5.0-rc1+dev124 nasa/sch_lab#87, v2.4.0-rc1+dev47 **Includes** *cFE* nasa/cFE#1903, Update directory diagrams in application developer guide nasa/cFE#1922, SB code coverage improvements #1905, Improve SB coverage nasa/cFE#1936, Improve ES code coverage nasa/cFE#1938, Enforce minimum code coverage nasa/cFE#1940, Update dev guide for MSG and SBR nasa/cFE#1941, Support unimplemented features in MSG FT *osal* nasa/osal#1144, Regex update in coverage enforcement to match .0 nasa/osal#1142, Add typecast to memchr call *psp* nasa/PSP#307, check that module type is not invalid nasa/PSP#306, do not override add_psp_module for coverage test *sch_lab* nasa/sch_lab#86, add CmdCode to sch_lab_table nasa/sch_lab#88, Fix missing typedef Co-authored-by: Jacob Hageman <[email protected]> Co-authored-by: Joseph Hickey <[email protected]> Co-authored-by: Ariel Adams <[email protected]> Co-authored-by: Jose F Martinez Pedraza <[email protected]>
astrogeco
added
CCB:Approved
|
CCB:2021-09-15 APPROVED |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
MSG Functional Tests won't pass on gateway cert repo that uses a custom MSG api. This PR makes the necessary changes to support unimplemented features in the custom API.
Testing performed
Steps taken to test the contribution:
Expected behavior changes
Verify that unimplemented features in MSG api don't result in failures
System(s) tested on
Additional context
Add any other context about the contribution here.
Third party code
If included, identify any third party code and provide text file of license
Contributor Info - All information REQUIRED for consideration of pull request
Jose F Martinez Pedraza / NASA GSFC