-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #609, Remove CFE_PLATFORM_EVS_LOG_ON undefined option to diasble log #1129
Fix #609, Remove CFE_PLATFORM_EVS_LOG_ON undefined option to diasble log #1129
Conversation
e8fe89a
to
dcadb67
Compare
CCB:2021-01-27 APPROVED
|
Need to remove control based on HK parameter before merge (will submit as an additional HOTFIX merge, or fasttrack?) |
@skliper this is in draft form, can I change this to ready? |
@astrogeco Good to go, opened #1153 to address the CCB actions. |
Should we address the requirements issue #1131 before merging this though? |
Nvm, clicked merge too soon :P |
Describe the contribution
Fix #609 - removes the ability to disable the log by not defining
CFE_PLATFORM_EVS_LOG_ON
Testing performed
Build and run unit tests, passed
Expected behavior changes
No longer able to disable log completely, for minimum memory use define
CFE_PLATFORM_EVS_LOG_MAX
as 1System(s) tested on
Additional context
Could remove control based on LogEnabled, panic on reset area fail and limp along if sem create fails.
Needs requirements updates - #1131
Third party code
None
Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC