Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CFE_ES_CDSRegDumpRec_t has implicit padding #966

Closed
skliper opened this issue Oct 27, 2020 · 2 comments · Fixed by #964 or #991
Closed

CFE_ES_CDSRegDumpRec_t has implicit padding #966

skliper opened this issue Oct 27, 2020 · 2 comments · Fixed by #964 or #991
Assignees
@jphickey
Labels
enhancement
Milestone
Caelum

Comments

@skliper
Copy link
Contributor

skliper commented Oct 27, 2020

Is your feature request related to a problem? Please describe.
Related to #664 - implicit padding should be avoided

Describe the solution you'd like
Eventually pack definitions will come from a common definition, with explicit padding

Describe alternatives you've considered
None

Additional context
Observed in testing Bootes

Requester Info
Jacob Hageman - NASA/GSFC

@wmoleski
@jphickey
Copy link
Contributor

Actually I noticed this as part of #909 because this structure is used for data files (and therefore should be included in the msg structs as it is part of the interface) and fixed it as part of that change.

@jphickey jphickey self-assigned this Oct 27, 2020
@jphickey
Copy link
Contributor

Checked again - there is one more thing needed here. Previous change fixed the name length to use mission-scope definition which is a multiple of 4, fixing that part of the problem, but there is still a padding due to the use of a bool value (1 byte) - so the alignment does need adjustment.

jphickey added a commit to jphickey/cFE that referenced this issue Oct 27, 2020
@jphickey
Fix nasa#966, update padding in CDS registry record
038fb9b 
As the name field is a multiple of 4 bytes, there needs to be 3 bytes
of padding, not 1, to avoid implicit padding.

This doesn't change anything, it just makes the padding explicit instead
of implicit.
jphickey added a commit to jphickey/cFE that referenced this issue Oct 27, 2020
@jphickey
Fix nasa#966, update padding in CDS registry record
5cd7ffc 
As the name field is a multiple of 4 bytes, there needs to be 3 bytes
of padding, not 1, to avoid implicit padding.

This doesn't change anything, it just makes the padding explicit instead
of implicit.
jphickey added a commit to jphickey/cFE that referenced this issue Oct 27, 2020
@jphickey
Fix nasa#966, update padding in CDS registry record
d21d94a 
As the name field is a multiple of 4 bytes, there needs to be 3 bytes
of padding, not 1, to avoid implicit padding.

This doesn't change anything, it just makes the padding explicit instead
of implicit.
@skliper skliper linked a pull request Oct 27, 2020 that will close this issue
Fix #966, update padding in CDS registry struct #969
Closed
@jphickey jphickey linked a pull request Oct 27, 2020 that will close this issue
Fix #909, reorganize ES public API + msg definitions #964
Merged
@astrogeco astrogeco mentioned this issue Nov 2, 2020
Merged
@skliper skliper added this to the 7.0.0 milestone Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jphickey jphickey

Labels
enhancement
Projects
None yet
Milestone
Caelum
2 participants
@jphickey @skliper