Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Data pointer argument to CFE_ES_CalculateCRC() should be const #52

Closed
skliper opened this issue Sep 30, 2019 · 3 comments
Closed

Data pointer argument to CFE_ES_CalculateCRC() should be const #52

skliper opened this issue Sep 30, 2019 · 3 comments
Labels
bug
Milestone
6.5.0

Comments

@skliper
Copy link
Contributor

skliper commented Sep 30, 2019

Since CFE_ES_CalculateCRC() does not modify the data passed into it, the pointer should be declared "const" in the prototype.

This will not affect any existing usage of the function, but it will allow usage in areas where the data is already "const".
@skliper skliper added this to the 6.5.0 milestone Sep 30, 2019
@skliper skliper self-assigned this Sep 30, 2019
@skliper skliper added the bug label Sep 30, 2019
@skliper
Copy link
Contributor Author

skliper commented Sep 30, 2019

Imported from trac issue 21. Created by jphickey on 2015-01-15T13:40:09, last modified: 2019-03-05T14:57:55

@skliper
Copy link
Contributor Author

skliper commented Sep 30, 2019

Trac comment by jphickey on 2015-01-26 13:04:27:

Ticket #59 addresses this plus other functions

@skliper
Copy link
Contributor Author

skliper commented Sep 30, 2019

Trac comment by jhageman on 2019-03-05 14:57:55:

Milestone renamed

@skliper skliper closed this as completed Sep 30, 2019
@skliper skliper mentioned this issue Sep 30, 2019
Closed
@skliper skliper removed their assignment Sep 30, 2019
CDKnightNASA added a commit to CDKnightNASA/cFE that referenced this issue May 11, 2020
@CDKnightNASA
missed a MID wrap, other fixes related to ticket nasa#666, nasa#52
9b779d8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
6.5.0
Development

No branches or pull requests
1 participant
@skliper