Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update unit tests to use correct command types #2228

Closed
dmknutsen opened this issue Dec 7, 2022 · 0 comments · Fixed by #2229
Closed

Update unit tests to use correct command types #2228

dmknutsen opened this issue Dec 7, 2022 · 0 comments · Fixed by #2229
Assignees
@dmknutsen
Labels
draco-rc4 unit-test
Milestone
Draco

Comments

@dmknutsen
Copy link
Contributor

dmknutsen commented Dec 7, 2022 •
edited
Loading

Is your feature request related to a problem? Please describe.
Update the unit tests to use the associated applicable command types in place of CFE_MSG_CommandHeader_t. This will allow for additional flexibility when modifying command definitions.

Note: This is the required unit test update(s) associated with #2220

Describe the solution you'd like
Replace CFE_MSG_CommandHeader_t with the corresponding command type(s) where applicable.

Requester Info
Dan Knutsen
NASA Goddard
dmknutsen pushed a commit to dmknutsen/cFE that referenced this issue Dec 7, 2022
Fix nasa#2228, Update UTs to use correct cmd types
eb2a052
@dmknutsen dmknutsen mentioned this issue Dec 7, 2022
Merged
2 tasks
@dmknutsen dmknutsen self-assigned this Dec 7, 2022
jphickey added a commit that referenced this issue Dec 9, 2022
@jphickey
Fix #2228, Use correct message types
0f9313d 
Update remaining cases where the CFE_MSG_CommandHeader_t was used for a
command that had no arguments, replacing it with a real data type that
is named according to the command.

In particular, this introduces a "SendHkCmd" type into all modules,
where previously the HK command used CFE_MSG_CommandHeader_t directly.
dzbaker added a commit that referenced this issue Dec 20, 2022
@dzbaker
Merge pull request #2229 from dmknutsen/ISSUE_2228
9b047b8 
Fix #2228, Update UTs to use correct cmd types
@dzbaker dzbaker mentioned this issue Dec 20, 2022
Merged
2 tasks
@dmknutsen dmknutsen added this to the Draco milestone Jan 18, 2023
jphickey pushed a commit to jphickey/cFE that referenced this issue Feb 1, 2023
@jphickey
Fix nasa#2228, Update UTs to use correct cmd types
2a49076 
Updates unit test and HK command handlers to use correct message data
types.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dmknutsen dmknutsen

Labels
draco-rc4 unit-test
Projects
None yet
Milestone
Draco
Development

Successfully merging a pull request may close this issue.

Fix #2228, Update UTs to use correct cmd types dmknutsen/cFE
1 participant
@dmknutsen