Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1541, Combine consecutive mutually exclusive #ifs #2191

Conversation

thnkslprpt
Copy link
Contributor

Checklist

Describe the contribution
Fixes #1541
Combines 2 (identical) cases of immediately consecutive, mutually exclusive #if/#endif blocks into a single #if/#else/#endif.

Testing performed
GitHub CI actions (incl. Build + Run, Unit Tests etc.) all passing successfully.

Expected behavior changes
No impact on behavior - logical flow is essentially unchanged.

Contributor Info
Avi Weiss @thnkslprpt

@dzbaker
Copy link
Collaborator

dzbaker commented Nov 3, 2022

CCB 3 November 2022: Want to take approach of making these runtime options (rather than being conditionally compiled). Will likely require some refactoring to time.

@dzbaker dzbaker closed this Nov 3, 2022
@thnkslprpt thnkslprpt deleted the fix-1541-combine-consecutive-mutually-exclusive-ifs branch November 3, 2022 20:44
@thnkslprpt thnkslprpt restored the fix-1541-combine-consecutive-mutually-exclusive-ifs branch November 3, 2022 20:45
@dmknutsen dmknutsen added this to the Draco milestone Jan 18, 2023
@thnkslprpt thnkslprpt deleted the fix-1541-combine-consecutive-mutually-exclusive-ifs branch January 23, 2023 23:09
@dmknutsen dmknutsen removed this from the Draco milestone Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Combine #if/#endif directives into #if/#else/#endif in CFE_TIME_Tone1HzISR
3 participants