Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine #if/#endif directives into #if/#else/#endif in CFE_TIME_Tone1HzISR #1541

Open
skliper opened this issue May 17, 2021 · 0 comments
Open

Comments

@skliper
Copy link
Contributor

skliper commented May 17, 2021

Is your feature request related to a problem? Please describe.
Mutually exclusive logic:

/*
** Maintain virtual MET as count of valid tone signal interrupts...
** (not set to zero by reset command)
*/
#if (CFE_PLATFORM_TIME_CFG_VIRTUAL == true)
CFE_TIME_Global.VirtualMET++;
#endif
/*
** Maintain virtual MET as count read from h/w MET register...
*/
#if (CFE_PLATFORM_TIME_CFG_VIRTUAL != true)
OS_GetLocalMET(&CFE_TIME_Global.VirtualMET);
#endif

Describe the solution you'd like
Use #if/#else/#endif

Describe alternatives you've considered
#302 would likely make this obsolete

Additional context
Code review

Requester Info
Jacob Hageman - NASA/GSFC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant