Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cast CFE_SUCCESS to CFE_Status_t #1311

Closed
skliper opened this issue Apr 13, 2021 · 0 comments · Fixed by #1374 or #1431
Closed

Cast CFE_SUCCESS to CFE_Status_t #1311

skliper opened this issue Apr 13, 2021 · 0 comments · Fixed by #1374 or #1431
Assignees
@jphickey
Labels
CFS-40 enhancement
Milestone
Caelum

Comments

@skliper
Copy link
Contributor

skliper commented Apr 13, 2021

Is your feature request related to a problem? Please describe.
CFE_SUCCESS doesn't match pattern for defining other CFE status returns:

cFE/modules/core_api/fsw/inc/cfe_error.h

Line 120 in e80aae9

#define CFE_SUCCESS (0)

Describe the solution you'd like
Cast as CFE_Status_t

Describe alternatives you've considered
Document why not

Additional context
CFS-40 code review

Requester Info
Jacob Hageman - NASA/GSFC
@skliper skliper added this to the 7.0.0 milestone Apr 13, 2021
@skliper skliper added the CFS-40 label Apr 13, 2021
jphickey added a commit to jphickey/cFE that referenced this issue Apr 16, 2021
@jphickey
Fix nasa#1311, CFE_SUCCESS constant type
14faa47 
Ensures that the CFE_SUCCESS constant is the CFE_Status_t type.
@jphickey jphickey mentioned this issue Apr 16, 2021
Merged
astrogeco added a commit that referenced this issue Apr 28, 2021
@astrogeco
Merge pull request #1374 from jphickey/fix-1311-cfe-status-type
bba169a 
Fix #1311, CFE_SUCCESS constant type
@astrogeco astrogeco mentioned this issue Apr 28, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jphickey jphickey

Labels
CFS-40 enhancement
Projects
None yet
Milestone
Caelum
2 participants
@jphickey @skliper