Fix #2378, refactor SB to support additional use cases

Cleans up the internal SB implementation so it can better support future enhancements such as message integrity, additional header fields and timestamping.
nasa · Apr 19, 2024 · ea02a67 · ea02a67
1 parent 9e5d452
commit ea02a67
Show file tree

Hide file tree

Showing 7 changed files with 2,554 additions and 1,487 deletions.
diff --git a/.github/workflows/code-coverage.yml b/.github/workflows/code-coverage.yml
@@ -104,8 +104,8 @@ jobs:
 
       - name: Confirm Minimum Coverage
         run: |
-          missed_branches=50
-          missed_lines=17
+          missed_branches=39
+          missed_lines=19
           branch_nums=$(grep -A 3 "Overall coverage rate" lcov_out.txt | grep branches | grep -oP "[0-9]+[0-9]*")
           line_nums=$(grep -A 3 "Overall coverage rate" lcov_out.txt | grep lines | grep -oP "[0-9]+[0-9]*")
 

diff --git a/modules/sb/fsw/src/cfe_sb_api.c b/modules/sb/fsw/src/cfe_sb_api.c
diff --git a/modules/sb/fsw/src/cfe_sb_buf.c b/modules/sb/fsw/src/cfe_sb_buf.c
@@ -128,7 +128,6 @@ CFE_SB_BufferD_t *CFE_SB_GetBufferFromPool(size_t MaxMsgSize)
     bd = (CFE_SB_BufferD_t *)addr;
     memset(bd, 0, CFE_SB_BUFFERD_CONTENT_OFFSET);
 
-    bd->MsgId         = CFE_SB_INVALID_MSG_ID;
     bd->UseCount      = 1;
     bd->AllocatedSize = AllocSize;