Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Size variables should use the size_t type #67

Closed
2 tasks done
thnkslprpt opened this issue Apr 10, 2023 · 0 comments · Fixed by #68
Closed
2 tasks done

Size variables should use the size_t type #67

thnkslprpt opened this issue Apr 10, 2023 · 0 comments · Fixed by #68

Comments

@thnkslprpt
Copy link
Contributor

Checklist

  • I reviewed the Contributing Guide.
  • I performed a cursory search to see if the bug report is relevant, not redundant, nor in conflict with other tickets.

Describe the bug
Most variables representing sizes in MM use size_t.
There are a few that do not follow this custom and could be transitioned over.

Code snips

uint16 ExpectedLength = sizeof(MM_PeekCmd_t);

bool MM_VerifyLoadDumpParams(cpuaddr Address, MM_MemType_t MemType, uint32 SizeInBytes, uint8 VerifyType)

Expected behavior
All size variables that can use size_t should do so - size_t is more expressive and more consistent with the relevant coding guidelines.

Reporter Info
Avi Weiss @thnkslprpt

thnkslprpt added a commit to thnkslprpt/MM that referenced this issue Apr 10, 2023
thnkslprpt added a commit to thnkslprpt/MM that referenced this issue Apr 22, 2023
thnkslprpt added a commit to thnkslprpt/MM that referenced this issue May 17, 2023
thnkslprpt added a commit to thnkslprpt/MM that referenced this issue May 25, 2023
thnkslprpt added a commit to thnkslprpt/MM that referenced this issue May 25, 2023
thnkslprpt added a commit to thnkslprpt/MM that referenced this issue May 25, 2023
thnkslprpt added a commit to thnkslprpt/MM that referenced this issue May 25, 2023
dzbaker added a commit that referenced this issue Jun 1, 2023
…iables

Fix #67, Use `size_t` for 'size' variables
@chillfig chillfig added this to the Equuleus milestone Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants