Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #77, Add break to default case of switch in LC_VerifyMsgLength #78

Merged
merged 1 commit into from
Apr 27, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docs/dox_src/cfs_lc.dox
Original file line number Diff line number Diff line change
Expand Up @@ -516,7 +516,7 @@
</I>

<B> (Q)
When would a actionpoint evalute to #LC_ACTION_STALE?
When would an actionpoint evalute to #LC_ACTION_STALE?
</B> <BR> <BR> <I>
#LC_ACTION_STALE is an initialization value for the Actionpoint
Results Table. If an actionpoint has this ActionResult then one of
Expand All @@ -534,7 +534,7 @@
</I>

<B> (Q)
When would a actionpoint evalute to #LC_ACTION_ERROR?
When would an actionpoint evalute to #LC_ACTION_ERROR?
</B> <BR> <BR> <I>
#LC_ACTION_ERROR is a runtime error indicator for actionpoint processing.
Such a result should be rare since most of the causes are invalid actionpoint
Expand Down
22 changes: 11 additions & 11 deletions fsw/inc/lc_events.h
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@

/**
* @file
* Specification for the CFS Limit Checker (LC) event identifers.
* Specification for the CFS Limit Checker (LC) event identifiers.
*/
#ifndef LC_EVENTS_H
#define LC_EVENTS_H
Expand Down Expand Up @@ -179,7 +179,7 @@
* \par Cause:
*
* This event message is issued when the CDS area for the
* watchpoint restuls table (WRT) data could not be registered.
* watchpoint results table (WRT) data could not be registered.
*/
#define LC_WRT_CDS_REGISTER_ERR_EID 12

Expand All @@ -191,7 +191,7 @@
* \par Cause:
*
* This event message is issued when the CDS area for the
* actionpont restuls table (ART) data could not be registered.
* actionpont results table (ART) data could not be registered.
*/
#define LC_ART_CDS_REGISTER_ERR_EID 13

Expand All @@ -208,7 +208,7 @@
#define LC_APP_CDS_REGISTER_ERR_EID 14

/**
* \brief LC Watchpoint Defintion Table Load From File Failed Event ID
* \brief LC Watchpoint Definition Table Load From File Failed Event ID
*
* \par Type: ERROR
*
Expand Down Expand Up @@ -539,7 +539,7 @@
#define LC_APSTATS_INF_EID 38

/**
* \brief LC Reset Watchpoint Stats Watchpoint Number Invalid Evnt ID
* \brief LC Reset Watchpoint Stats Watchpoint Number Invalid Event ID
*
* \par Type: ERROR
*
Expand Down Expand Up @@ -581,7 +581,7 @@
*
* \par Cause:
*
* This event message is issued when a actionpoint sample request is received
* This event message is issued when an actionpoint sample request is received
* with a message length that doesn't match the expected value.
*/
#define LC_APSAMPLE_LEN_ERR_EID 42
Expand Down Expand Up @@ -686,7 +686,7 @@
#define LC_WP_DATATYPE_ERR_EID 50

/**
* \brief LC Watchpoint Operatior ID Invalid Event ID
* \brief LC Watchpoint Operator ID Invalid Event ID
*
* \par Type: ERROR
*
Expand Down Expand Up @@ -724,7 +724,7 @@
#define LC_WP_OFFSET_ERR_EID 53

/**
* \brief LC Watchpoint Defintion Table Validation Floating Point Check Failed Event ID
* \brief LC Watchpoint Definition Table Validation Floating Point Check Failed Event ID
*
* \par Type: ERROR
*
Expand Down Expand Up @@ -752,7 +752,7 @@
#define LC_WDTVAL_ERR_EID 55

/**
* \brief LC Watchpoint Defintion Table Validation Results Event ID
* \brief LC Watchpoint Definition Table Validation Results Event ID
*
* \par Type: INFORMATION
*
Expand Down Expand Up @@ -856,7 +856,7 @@
* \par Cause:
*
* This event message is issued on the first error when a table validation
* fails for a actionpoint definition table (ADT) load and the error is
* fails for an actionpoint definition table (ADT) load and the error is
* a failed RPN equation check.
*/
#define LC_ADTVAL_RPNERR_EID 64
Expand All @@ -875,7 +875,7 @@
#define LC_ADTVAL_ERR_EID 65

/**
* \brief LC Actionpoint Defintion Table Validation Result Event ID
* \brief LC Actionpoint Definition Table Validation Result Event ID
*
* \par Type: INFORMATION
*
Expand Down
2 changes: 1 addition & 1 deletion fsw/inc/lc_platform_cfg.h
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,7 @@
*
* \par Description:
* The maximum RTS ID that LC will allow during table
* validation in a Actionpoint Definition Table (ADT) entry
* validation in an Actionpoint Definition Table (ADT) entry
*
* \par Limits:
* This parameter can't be larger than an unsigned 16 bit
Expand Down
4 changes: 2 additions & 2 deletions fsw/src/lc_app.c
Original file line number Diff line number Diff line change
Expand Up @@ -335,12 +335,12 @@ int32 LC_TableInit(void)
** LC task use of Critical Data Store (CDS)
**
** Global application data (LC_AppData)
** Watchpint results dump only table data
** Watchpoint results dump only table data
** Actionpoint results dump only table data
**
** cFE Table Services use of CDS for LC task
**
** Watchpint definition loadable table data
** Watchpoint definition loadable table data
** Actionpoint definition loadable table data
**
** LC table initialization logic re CDS
Expand Down
1 change: 1 addition & 0 deletions fsw/src/lc_dispatch.c
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,7 @@ bool LC_VerifyMsgLength(const CFE_MSG_Message_t *MsgPtr, size_t ExpectedLength)
(unsigned long)CFE_SB_MsgIdToValue(MessageID), CommandCode, (int)ActualLength,
(int)ExpectedLength);
LC_AppData.CmdErrCount++;
break;
}

result = false;
Expand Down
2 changes: 1 addition & 1 deletion fsw/src/lc_watch.h
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,7 @@ uint8 LC_UnsignedCompare(uint16 WatchIndex, uint32 WPValue, uint32 CompareValue)
*
* \par Description
* Support function for watchpoint processing that will perform
* an floating point watchpoint data comparison based upon the operator
* a floating point watchpoint data comparison based upon the operator
* specified in the watchpoint definition table
*
* \par Assumptions, External Events, and Notes:
Expand Down