Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Health and Safety has extraneous code #10

Closed
skliper opened this issue Apr 22, 2022 · 1 comment · Fixed by #17
Closed

Health and Safety has extraneous code #10

skliper opened this issue Apr 22, 2022 · 1 comment · Fixed by #17
Labels
draco-rc2 enhancement
Milestone
Draco

Comments

@skliper
Copy link
Contributor

skliper commented Apr 22, 2022

IVV Severity: 4

Issue Category: Code
Issue Type: Extraneous Code
Count: 1

Description:
The Health and Safety App init function includes the extraneous assignment of Status to CFE_SUCCESS[1: line 355]; however, this value is never used again before the value of Status is reassigned[1: line 381].

Recommended Actions:
The assignment statement for Status can be removed.

Impact:
Defect impacting maintainability on current mission or reuse on future missions.

Imported from GSFCCFS-1901
@skliper
Copy link
Contributor Author

skliper commented May 9, 2022

Related to #16

skliper added a commit to skliper/HS that referenced this issue May 9, 2022
@skliper
Fix nasa#16 nasa#10, Resolve reassignment before use style warnings
367719b
@skliper skliper mentioned this issue May 9, 2022
Merged
2 tasks
astrogeco added a commit that referenced this issue May 11, 2022
@astrogeco
Merge pull request #17 from skliper/fix16-static_analysis_warnings
c5ef5ac 
Fix #16 #10, Resolve reassignment before use style warnings
@skliper skliper added this to the Draco milestone Jul 14, 2022
This was referenced Feb 14, 2023
Closed
Closed
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
draco-rc2 enhancement
Projects
None yet
Milestone
Draco
Development

Successfully merging a pull request may close this issue.

Fix #16 #10, Resolve reassignment before use style warnings skliper/HS
1 participant
@skliper